Skip to content

Remove table-node files and references#18

Merged
akshad-exe merged 3 commits into
feature/tiptapfrom
copilot/sub-pr-17
Feb 9, 2026
Merged

Remove table-node files and references#18
akshad-exe merged 3 commits into
feature/tiptapfrom
copilot/sub-pr-17

Conversation

Copilot AI commented Feb 9, 2026

Copy link
Copy Markdown
Contributor

Complete removal of table-node component files to resolve merge conflicts.

Changes

Deleted files (11 total):

  • SCSS: table-cell-handle-menu.scss, table-extend-row-column-button.scss, table-handle.scss, table-node.scss, table-selection-overlay.scss, table-trigger-button.scss
  • Components: TableCellHandleMenu.tsx, TableExtendRowColumnButtons.tsx, TableHandle.tsx, TableSelectionOverlay.tsx, TableTriggerButton.tsx

Cleaned up imports:

  • editor/ui/tiptapEditor.tsx - removed table-node.scss import
  • editor/components/tiptap-templates/simple/simple-editor.tsx - removed table-node.scss import

The table-node directory has been removed entirely.


💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.

Copilot AI changed the title [WIP] Remove table-node and related files to resolve merge conflicts Revert table-node changes to resolve merge conflicts Feb 9, 2026
Copilot AI requested a review from akshad-exe February 9, 2026 02:21
Copilot AI changed the title Revert table-node changes to resolve merge conflicts Remove table-node files and references Feb 9, 2026
@akshad-exe akshad-exe marked this pull request as ready for review February 9, 2026 02:27
Copilot AI review requested due to automatic review settings February 9, 2026 02:27
@akshad-exe akshad-exe merged commit 51f5dee into feature/tiptap Feb 9, 2026
2 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the legacy table-node component directory (UI components/hooks/styles/extensions) and cleans up remaining stylesheet imports that referenced it, primarily to reduce merge-conflict surface area.

Changes:

  • Deleted the editor/components/tiptap-node/table-node/** tree (UI controls, hooks, extensions, and SCSS).
  • Removed table-node.scss imports from the main editor entrypoints.

Reviewed changes

Copilot reviewed 64 out of 64 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
editor/ui/tiptapEditor.tsx Removes the table-node stylesheet import from the editor entrypoint.
editor/components/tiptap-templates/simple/simple-editor.tsx Removes the table-node stylesheet import from the SimpleEditor template.
editor/components/tiptap-node/table-node/ui/table-trigger-button/use-table-trigger.ts Deleted: table insert trigger hook.
editor/components/tiptap-node/table-node/ui/table-trigger-button/table-trigger-button.tsx Deleted: table insert trigger UI.
editor/components/tiptap-node/table-node/ui/table-trigger-button/table-grid-selector.tsx Deleted: table size grid selector.
editor/components/tiptap-node/table-node/ui/table-trigger-button/table-grid-selector.scss Deleted: grid selector styles.
editor/components/tiptap-node/table-node/ui/table-trigger-button/index.tsx Deleted: barrel exports.
editor/components/tiptap-node/table-node/ui/table-sort-row-column-button/use-table-sort-row-column.ts Deleted: row/column sorting hook.
editor/components/tiptap-node/table-node/ui/table-sort-row-column-button/table-sort-row-column-button.tsx Deleted: sorting button UI.
editor/components/tiptap-node/table-node/ui/table-sort-row-column-button/index.tsx Deleted: barrel exports.
editor/components/tiptap-node/table-node/ui/table-selection-overlay/use-resize-overlay.ts Deleted: resize overlay hook.
editor/components/tiptap-node/table-node/ui/table-selection-overlay/table-selection-overlay.tsx Deleted: selection/resize overlay UI.
editor/components/tiptap-node/table-node/ui/table-selection-overlay/index.tsx Deleted: barrel exports.
editor/components/tiptap-node/table-node/ui/table-move-row-column-button/use-table-move-row-column.ts Deleted: move row/column hook.
editor/components/tiptap-node/table-node/ui/table-move-row-column-button/table-move-row-column-button.tsx Deleted: move button UI.
editor/components/tiptap-node/table-node/ui/table-move-row-column-button/index.tsx Deleted: barrel exports.
editor/components/tiptap-node/table-node/ui/table-merge-split-cell-button/use-table-merge-split-cell.ts Deleted: merge/split hook.
editor/components/tiptap-node/table-node/ui/table-merge-split-cell-button/table-merge-split-cell-button.tsx Deleted: merge/split button UI.
editor/components/tiptap-node/table-node/ui/table-merge-split-cell-button/index.tsx Deleted: barrel exports.
editor/components/tiptap-node/table-node/ui/table-header-row-column-button/use-table-header-row-column.ts Deleted: header toggle hook.
editor/components/tiptap-node/table-node/ui/table-header-row-column-button/table-header-row-column-button.tsx Deleted: header toggle button UI.
editor/components/tiptap-node/table-node/ui/table-header-row-column-button/index.tsx Deleted: barrel exports.
editor/components/tiptap-node/table-node/ui/table-handle/use-table-handle-positioning.ts Deleted: handle positioning hook.
editor/components/tiptap-node/table-node/ui/table-handle/table-handle.tsx Deleted: table handle container UI.
editor/components/tiptap-node/table-node/ui/table-handle/index.tsx Deleted: barrel exports.
editor/components/tiptap-node/table-node/ui/table-handle-menu/table-handle-menu.tsx Deleted: handle menu UI.
editor/components/tiptap-node/table-node/ui/table-handle-menu/table-handle-menu.scss Deleted: handle menu styles.
editor/components/tiptap-node/table-node/ui/table-handle-menu/index.tsx Deleted: barrel exports.
editor/components/tiptap-node/table-node/ui/table-fit-to-width-button/use-table-fit-to-width.ts Deleted: fit-to-width hook.
editor/components/tiptap-node/table-node/ui/table-fit-to-width-button/table-fit-to-width-button.tsx Deleted: fit-to-width button UI.
editor/components/tiptap-node/table-node/ui/table-fit-to-width-button/index.tsx Deleted: barrel exports.
editor/components/tiptap-node/table-node/ui/table-extend-row-column-button/use-table-extend-row-column.ts Deleted: extend buttons positioning hook.
editor/components/tiptap-node/table-node/ui/table-extend-row-column-button/table-extend-row-column-button.tsx Deleted: extend row/column buttons UI.
editor/components/tiptap-node/table-node/ui/table-extend-row-column-button/table-extend-row-column-button.scss Deleted: extend button styles.
editor/components/tiptap-node/table-node/ui/table-extend-row-column-button/index.tsx Deleted: barrel exports.
editor/components/tiptap-node/table-node/ui/table-duplicate-row-column-button/use-table-duplicate-row-column.ts Deleted: duplicate hook.
editor/components/tiptap-node/table-node/ui/table-duplicate-row-column-button/table-duplicate-row-column-button.tsx Deleted: duplicate button UI.
editor/components/tiptap-node/table-node/ui/table-duplicate-row-column-button/index.tsx Deleted: barrel exports.
editor/components/tiptap-node/table-node/ui/table-delete-row-column-button/use-table-delete-row-column.ts Deleted: delete hook.
editor/components/tiptap-node/table-node/ui/table-delete-row-column-button/table-delete-row-column-button.tsx Deleted: delete button UI.
editor/components/tiptap-node/table-node/ui/table-delete-row-column-button/index.tsx Deleted: barrel exports.
editor/components/tiptap-node/table-node/ui/table-clear-row-column-content-button/use-table-clear-row-column-content.ts Deleted: clear content hook.
editor/components/tiptap-node/table-node/ui/table-clear-row-column-content-button/table-clear-row-column-content-button.tsx Deleted: clear content button UI.
editor/components/tiptap-node/table-node/ui/table-clear-row-column-content-button/index.tsx Deleted: barrel exports.
editor/components/tiptap-node/table-node/ui/table-cell-handle-menu/table-cell-handle-menu.tsx Deleted: cell handle menu UI.
editor/components/tiptap-node/table-node/ui/table-cell-handle-menu/table-cell-handle-menu.scss Deleted: cell handle menu styles.
editor/components/tiptap-node/table-node/ui/table-cell-handle-menu/index.tsx Deleted: barrel exports.
editor/components/tiptap-node/table-node/ui/table-alignment-menu/table-alignment-menu.tsx Deleted: alignment menu UI.
editor/components/tiptap-node/table-node/ui/table-alignment-menu/index.tsx Deleted: barrel exports.
editor/components/tiptap-node/table-node/ui/table-align-cell-button/use-table-align-cell.ts Deleted: align cell hook.
editor/components/tiptap-node/table-node/ui/table-align-cell-button/table-align-cell-button.tsx Deleted: align cell button UI.
editor/components/tiptap-node/table-node/ui/table-align-cell-button/index.tsx Deleted: barrel exports.
editor/components/tiptap-node/table-node/ui/table-add-row-column-button/use-table-add-row-column.ts Deleted: add row/column hook.
editor/components/tiptap-node/table-node/ui/table-add-row-column-button/table-add-row-column-button.tsx Deleted: add row/column button UI.
editor/components/tiptap-node/table-node/ui/table-add-row-column-button/index.tsx Deleted: barrel exports.
editor/components/tiptap-node/table-node/styles/table-node.scss Deleted: table styling rules (borders/padding/resize handle/etc.).
editor/components/tiptap-node/table-node/styles/prosemirror-table.scss Deleted: ProseMirror table baseline styling.
editor/components/tiptap-node/table-node/hooks/use-table-handle-state.ts Deleted: table handle state hook.
editor/components/tiptap-node/table-node/extensions/table-node-extension.ts Deleted: custom table node extension/nodeview.
editor/components/tiptap-node/table-node/extensions/table-handle/table-handle.ts Deleted: handle extension commands/events.
editor/components/tiptap-node/table-node/extensions/table-handle/table-handle-plugin.ts Deleted: handle plugin implementation.
editor/components/tiptap-node/table-node/extensions/table-handle/index.ts Deleted: barrel exports.
editor/components/tiptap-node/table-node/extensions/table-handle/helpers/create-image.ts Deleted: drag-image helper.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines 37 to 41
import "@/components/tiptap-node/list-node/list-node.scss"
import "@/components/tiptap-node/image-node/image-node.scss"
import "@/components/tiptap-node/heading-node/heading-node.scss"
import "@/components/tiptap-node/paragraph-node/paragraph-node.scss"
import "@/components/tiptap-node/table-node/table-node.scss"
import "@/components/tiptap-templates/simple/simple-editor.scss"

Copilot AI Feb 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TableExtension is still enabled (tables can be inserted via SlashSuggestion), but this PR removes the only table styling import. After this change, there appear to be no remaining .ProseMirror/table CSS (e.g., for .column-resize-handle, .selectedCell, basic borders/padding), which will likely break table appearance and column resizing UX. Consider reintroducing minimal table styles in a new/shared stylesheet (or import the recommended prosemirror-tables styles) or, if tables are no longer supported, remove TableExtension and related commands instead.

Copilot uses AI. Check for mistakes.
Comment on lines 38 to 41
import "@/components/tiptap-node/image-node/image-node.scss"
import "@/components/tiptap-node/heading-node/heading-node.scss"
import "@/components/tiptap-node/paragraph-node/paragraph-node.scss"
import "@/components/tiptap-node/table-node/table-node.scss"
import "@/components/tiptap-templates/simple/simple-editor.scss"

Copilot AI Feb 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR description says only 11 files were deleted, but the diff removes the entire table-node implementation (many TS/SCSS files, hooks, extensions, and styles). Please update the PR description to reflect the full scope so reviewers can assess the impact correctly (e.g., whether table UI features are intentionally removed vs. just resolving conflicts).

Copilot uses AI. Check for mistakes.
Comment on lines 34 to 39
import "@/components/tiptap-node/horizontal-rule-node/horizontal-rule-node.scss"
import "@/components/tiptap-node/list-node/list-node.scss"
import "@/components/tiptap-node/image-node/image-node.scss"
import "@/components/tiptap-node/heading-node/heading-node.scss"
import "@/components/tiptap-node/paragraph-node/paragraph-node.scss"
import "@/components/tiptap-node/table-node/table-node.scss"

Copilot AI Feb 9, 2026

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TableExtension is still included in this editor, but this PR removes the table stylesheet import and the repo no longer appears to contain any table-related CSS. That will likely regress table rendering/selection/resizing behavior. Please add replacement table styles (or re-add the needed stylesheet in a new location) or remove table support if it’s intentionally being dropped.

Copilot uses AI. Check for mistakes.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants