Skip to content

Commit 6ee86a6

Browse files
thundernixonthundernixon
committed
resolve and document fontbakery FAILs
1 parent 7919f1e commit 6ee86a6

File tree

11 files changed

+230
-123
lines changed

11 files changed

+230
-123
lines changed

‎FiraCode.glyphs‎

Lines changed: 30 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -234,31 +234,31 @@ capHeight = 1374;
234234
customParameters = (
235235
{
236236
name = typoAscender;
237-
value = 1870;
237+
value = 1980;
238238
},
239239
{
240240
name = typoDescender;
241-
value = -530;
241+
value = -644;
242242
},
243243
{
244244
name = typoLineGap;
245245
value = 0;
246246
},
247247
{
248248
name = winAscent;
249-
value = 1870;
249+
value = 2164;
250250
},
251251
{
252252
name = winDescent;
253-
value = 530;
253+
value = 1000;
254254
},
255255
{
256256
name = hheaAscender;
257-
value = 1870;
257+
value = 1980;
258258
},
259259
{
260260
name = hheaDescender;
261-
value = -530;
261+
value = -644;
262262
},
263263
{
264264
name = hheaLineGap;
@@ -300,31 +300,31 @@ capHeight = 1386;
300300
customParameters = (
301301
{
302302
name = typoAscender;
303-
value = 1870;
303+
value = 1980;
304304
},
305305
{
306306
name = typoDescender;
307-
value = -530;
307+
value = -644;
308308
},
309309
{
310310
name = typoLineGap;
311311
value = 0;
312312
},
313313
{
314314
name = winAscent;
315-
value = 1870;
315+
value = 2164;
316316
},
317317
{
318318
name = winDescent;
319-
value = 530;
319+
value = 1000;
320320
},
321321
{
322322
name = hheaAscender;
323-
value = 1870;
323+
value = 1980;
324324
},
325325
{
326326
name = hheaDescender;
327-
value = -530;
327+
value = -644;
328328
},
329329
{
330330
name = hheaLineGap;
@@ -107244,6 +107244,10 @@ name = "Remove Features";
107244107244
value = (
107245107245
cpsp
107246107246
);
107247+
},
107248+
{
107249+
name = weightClass;
107250+
value = 300;
107247107251
}
107248107252
);
107249107253
interpolationWeight = 62;
@@ -107260,6 +107264,10 @@ name = "Remove Features";
107260107264
value = (
107261107265
cpsp
107262107266
);
107267+
},
107268+
{
107269+
name = weightClass;
107270+
value = 400;
107263107271
}
107264107272
);
107265107273
interpolationWeight = 84;
@@ -107270,11 +107278,10 @@ instanceInterpolations = {
107270107278
name = Regular;
107271107279
},
107272107280
{
107273-
exports = 0;
107274107281
customParameters = (
107275107282
{
107276107283
name = weightClass;
107277-
value = 900;
107284+
value = 450;
107278107285
},
107279107286
{
107280107287
name = "Remove Features";
@@ -107289,6 +107296,7 @@ instanceInterpolations = {
107289107296
"B67F0F2D-EC95-4CB8-966E-23AE86958A69" = 0.64583;
107290107297
};
107291107298
name = Retina;
107299+
weightClass = Normal;
107292107300
},
107293107301
{
107294107302
customParameters = (
@@ -107297,6 +107305,10 @@ name = "Remove Features";
107297107305
value = (
107298107306
cpsp
107299107307
);
107308+
},
107309+
{
107310+
name = weightClass;
107311+
value = 500;
107300107312
}
107301107313
);
107302107314
interpolationWeight = 112;
@@ -107334,6 +107346,10 @@ name = "Remove Features";
107334107346
value = (
107335107347
cpsp
107336107348
);
107349+
},
107350+
{
107351+
name = weightClass;
107352+
value = 700;
107337107353
}
107338107354
);
107339107355
interpolationWeight = 158;

‎distr/ttf/FiraCode-Bold.ttf‎

0 Bytes
Binary file not shown.

‎distr/ttf/FiraCode-Light.ttf‎

0 Bytes
Binary file not shown.

‎distr/ttf/FiraCode-Medium.ttf‎

0 Bytes
Binary file not shown.

‎distr/ttf/FiraCode-Regular.ttf‎

0 Bytes
Binary file not shown.

‎distr/ttf/FiraCode-Retina.ttf‎

0 Bytes
Binary file not shown.

‎distr/variable_ttf/FiraCode-VF.ttf‎

56 Bytes
Binary file not shown.

‎distr/variable_ttf/FiraCode-VF.ttx‎

Lines changed: 0 additions & 57 deletions
This file was deleted.

‎googlefonts-qa/checks/FiraCode-Light.checks.md‎

Lines changed: 13 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -267,11 +267,10 @@ But instead we have got: 'Copyright 2012-2015 The Mozilla Foundation, Telefonica
267267

268268
</details>
269269
<details>
270-
<summary>🔥 <b>FAIL:</b> Checking OS/2 usWinAscent & usWinDescent.</summary>
270+
<summary>🔥 <b>FAIL:</b> Variable font weight coordinates must be multiples of 100.</summary>
271271

272-
* [com.google.fonts/check/family/win_ascent_and_descent](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/family/win_ascent_and_descent)
273-
* 🔥 **FAIL** OS/2.usWinAscent value should be equal or greater than 2100, but got 1870 instead [code: ascent]
274-
* 🔥 **FAIL** OS/2.usWinDescent value should be equal or greater than 1000, but got 530 instead [code: descent]
272+
* [com.google.fonts/check/varfont_weight_instances](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/varfont_weight_instances)
273+
* 🔥 **FAIL** Found an variable font instance with 'wght'=450.0. This should instead be a multiple of 100.
275274

276275
</details>
277276
<details>
@@ -444,9 +443,9 @@ But instead we have got: 'Copyright 2012-2015 The Mozilla Foundation, Telefonica
444443

445444
| | FiraCode-Light.ttf |
446445
|:--- | ---:|
447-
| Dehinted Size | 238.0kb |
446+
| Dehinted Size | 238.1kb |
448447
| Hinted Size | 236.1kb |
449-
| Increase | -1996 bytes |
448+
| Increase | -1992 bytes |
450449
| Change | -0.8 % |
451450

452451

@@ -494,7 +493,7 @@ The version string must ideally include a git commit hash and either a 'dev' or
494493
<summary>ℹ <b>INFO:</b> Font contains all required tables?</summary>
495494

496495
* [com.google.fonts/check/required_tables](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/required_tables)
497-
* ℹ **INFO** This font contains the following optional tables [GPOS, gasp, DSIG, loca, GSUB, prep]
496+
* ℹ **INFO** This font contains the following optional tables [GSUB, loca, GPOS, DSIG, gasp, prep]
498497
* 🍞 **PASS** Font contains all required tables.
499498

500499
</details>
@@ -808,6 +807,13 @@ The version string must ideally include a git commit hash and either a 'dev' or
808807
* [com.google.fonts/check/varfont/has_HVAR](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/varfont/has_HVAR)
809808
* 🍞 **PASS** This variable font contains an HVAR table.
810809

810+
</details>
811+
<details>
812+
<summary>🍞 <b>PASS:</b> Checking OS/2 usWinAscent & usWinDescent.</summary>
813+
814+
* [com.google.fonts/check/family/win_ascent_and_descent](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/family/win_ascent_and_descent)
815+
* 🍞 **PASS** OS/2 usWinAscent & usWinDescent values look good!
816+
811817
</details>
812818
<details>
813819
<summary>🍞 <b>PASS:</b> Checking OS/2 Metrics match hhea Metrics.</summary>
@@ -850,13 +856,6 @@ The version string must ideally include a git commit hash and either a 'dev' or
850856
* [com.google.fonts/check/varfont_has_instances](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/varfont_has_instances)
851857
* 🍞 **PASS** OK
852858

853-
</details>
854-
<details>
855-
<summary>🍞 <b>PASS:</b> Variable font weight coordinates must be multiples of 100.</summary>
856-
857-
* [com.google.fonts/check/varfont_weight_instances](https://github.com/googlefonts/fontbakery/search?q=com.google.fonts/check/varfont_weight_instances)
858-
* 🍞 **PASS** OK
859-
860859
</details>
861860
<details>
862861
<summary>🍞 <b>PASS:</b> Checking with ftxvalidator.</summary>

0 commit comments

Comments
 (0)