Repository navigation
Commit c664bdd
fix: prefer pointer events over semantics tap for mouse clicks on web (flutter#191529)
This PR fixes `Tap*Details` reporting the center of the semantics node
and `PointerDeviceKind.unknown` for mouse clicks on web when semantics
is enabled.
When semantics is enabled, `ClickDebouncer` withholds the pointer events
that lead up to a DOM "click" on a tappable semantics node and forwards
the click as a `SemanticsAction.tap` instead. That action carries
neither a position nor a device kind, so the framework synthesizes the
tap at the center of the semantics node with
`PointerDeviceKind.unknown`. For a merged semantics node that also means
the tap is attributed to the merged node rather than to whatever was
actually under the cursor.
The debouncer exists for assistive technologies, which drive taps either
through clicks that come with no pointer events at all, or through
touch. Neither of those paths is affected by this change: when the
withheld pointer events came from a mouse, they are now flushed to the
framework and the click is dropped, so mouse gestures are recognized
exactly like they are when semantics is off.
Fixes: flutter#188859
Fixes: flutter#146063
## Pre-launch Checklist
- [x] I read the [Contributor Guide] and followed the process outlined
there for submitting PRs.
- [x] I read the [AI contribution guidelines] and understand my
responsibilities, or I am not using AI tools.
- [x] I read the [Tree Hygiene] wiki page, which explains my
responsibilities.
- [x] I read and followed the [Flutter Style Guide], including [Features
we expect every widget to implement].
- [x] I signed the [CLA].
- [x] I listed at least one issue that this PR fixes in the description
above.
- [x] I updated/added relevant documentation (doc comments with `///`).
- [x] I added new tests to check the change I am making, or this PR is
[test-exempt].
- [x] I followed the [breaking change policy] and added [Data Driven
Fixes] where supported.
- [x] All existing and new tests are passing.
<!-- Links -->
[Contributor Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#overview
[AI contribution guidelines]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#ai-contribution-guidelines
[Tree Hygiene]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md
[test-exempt]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#tests
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md
[Features we expect every widget to implement]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Style-guide-for-Flutter-repo.md#features-we-expect-every-widget-to-implement
[CLA]: https://cla.developers.google.com/
[breaking change policy]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Tree-hygiene.md#handling-breaking-changes
[Data Driven Fixes]:
https://github.com/flutter/flutter/blob/main/docs/contributing/Data-driven-Fixes.md
---------
Co-authored-by: zhongliugo <[email protected]>1 parent d811479 commit c664bdd
2 files changed
Lines changed: 115 additions & 4 deletions
File tree
- engine/src/flutter/lib/web_ui
- lib/src/engine
- test/engine
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
212 | 212 | | |
213 | 213 | | |
214 | 214 | | |
215 | | - | |
| 215 | + | |
| 216 | + | |
| 217 | + | |
| 218 | + | |
216 | 219 | | |
217 | 220 | | |
218 | 221 | | |
| |||
245 | 248 | | |
246 | 249 | | |
247 | 250 | | |
| 251 | + | |
| 252 | + | |
| 253 | + | |
| 254 | + | |
| 255 | + | |
| 256 | + | |
| 257 | + | |
| 258 | + | |
| 259 | + | |
| 260 | + | |
| 261 | + | |
| 262 | + | |
| 263 | + | |
| 264 | + | |
| 265 | + | |
| 266 | + | |
| 267 | + | |
| 268 | + | |
| 269 | + | |
| 270 | + | |
248 | 271 | | |
249 | 272 | | |
250 | 273 | | |
| |||
301 | 324 | | |
302 | 325 | | |
303 | 326 | | |
| 327 | + | |
| 328 | + | |
| 329 | + | |
| 330 | + | |
| 331 | + | |
| 332 | + | |
| 333 | + | |
| 334 | + | |
| 335 | + | |
| 336 | + | |
| 337 | + | |
| 338 | + | |
| 339 | + | |
| 340 | + | |
| 341 | + | |
| 342 | + | |
| 343 | + | |
| 344 | + | |
304 | 345 | | |
305 | 346 | | |
306 | 347 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
3433 | 3433 | | |
3434 | 3434 | | |
3435 | 3435 | | |
| 3436 | + | |
| 3437 | + | |
| 3438 | + | |
| 3439 | + | |
| 3440 | + | |
| 3441 | + | |
| 3442 | + | |
3436 | 3443 | | |
3437 | 3444 | | |
3438 | 3445 | | |
| |||
3546 | 3553 | | |
3547 | 3554 | | |
3548 | 3555 | | |
3549 | | - | |
| 3556 | + | |
3550 | 3557 | | |
3551 | 3558 | | |
3552 | 3559 | | |
| |||
3576 | 3583 | | |
3577 | 3584 | | |
3578 | 3585 | | |
3579 | | - | |
| 3586 | + | |
3580 | 3587 | | |
3581 | 3588 | | |
3582 | 3589 | | |
3583 | 3590 | | |
3584 | 3591 | | |
3585 | | - | |
| 3592 | + | |
3586 | 3593 | | |
3587 | 3594 | | |
3588 | 3595 | | |
| |||
3718 | 3725 | | |
3719 | 3726 | | |
3720 | 3727 | | |
| 3728 | + | |
| 3729 | + | |
| 3730 | + | |
| 3731 | + | |
| 3732 | + | |
| 3733 | + | |
| 3734 | + | |
| 3735 | + | |
| 3736 | + | |
| 3737 | + | |
| 3738 | + | |
| 3739 | + | |
| 3740 | + | |
| 3741 | + | |
| 3742 | + | |
| 3743 | + | |
| 3744 | + | |
| 3745 | + | |
| 3746 | + | |
| 3747 | + | |
| 3748 | + | |
| 3749 | + | |
| 3750 | + | |
| 3751 | + | |
| 3752 | + | |
| 3753 | + | |
3721 | 3754 | | |
3722 | 3755 | | |
3723 | 3756 | | |
3724 | 3757 | | |
3725 | 3758 | | |
3726 | 3759 | | |
3727 | 3760 | | |
| 3761 | + | |
| 3762 | + | |
| 3763 | + | |
| 3764 | + | |
| 3765 | + | |
| 3766 | + | |
| 3767 | + | |
3728 | 3768 | | |
3729 | 3769 | | |
3730 | 3770 | | |
3731 | 3771 | | |
| 3772 | + | |
| 3773 | + | |
| 3774 | + | |
| 3775 | + | |
| 3776 | + | |
| 3777 | + | |
| 3778 | + | |
| 3779 | + | |
| 3780 | + | |
| 3781 | + | |
| 3782 | + | |
| 3783 | + | |
| 3784 | + | |
| 3785 | + | |
| 3786 | + | |
| 3787 | + | |
| 3788 | + | |
3732 | 3789 | | |
| 3790 | + | |
| 3791 | + | |
| 3792 | + | |
| 3793 | + | |
| 3794 | + | |
| 3795 | + | |
| 3796 | + | |
| 3797 | + | |
| 3798 | + | |
| 3799 | + | |
| 3800 | + | |
3733 | 3801 | | |
| 3802 | + | |
| 3803 | + | |
3734 | 3804 | | |
3735 | 3805 | | |
3736 | 3806 | | |
| |||
0 commit comments