Skip to content

Conversation

@ns6089
Copy link

@ns6089 ns6089 commented Oct 11, 2023

Description

Windows uses larger icon now than typical "large" icon, which is only 32px.
On Windows 10 it's 52px on balloon and 42px in action center.
This PR changes the provided icon to 64px, it's downscaled without visible artifacts and gives some breathing room in case Windows decided to change it again in the future.
For DPI scaling, icon size should scale up proportionally without an issue.

Screenshot

2023-10-11 12_04_35-Window
2023-10-11 12_05_42-Window

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@TheElixZammuto
Copy link
Member

Working as intended, LGTM

@ReenigneArcher ReenigneArcher merged commit 2664388 into LizardByte:master Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants