Skip to content

fix(crowdin): expose initCrowdIn to global scope #99

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 1 commit into from
Mar 23, 2025
Merged

fix(crowdin): expose initCrowdIn to global scope #99

ReenigneArcher merged 1 commit into from
Mar 23, 2025

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Mar 23, 2025

Description

initCrowdIn cannot be accessed as it's not exposed to the global scope.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@codecov
Copy link

codecov bot commented Mar 23, 2025

Bundle Report

Changes will increase total bundle size by 54 bytes (0.22%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
shared-web-array-push 24.95kB 54 bytes (0.22%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: shared-web-array-push

Assets Changed:

Asset Name Size Change Total Size Change (%)
crowdin.js 54 bytes 3.93kB 1.39%

Files in crowdin.js:

  • ./src/js/crowdin.js → Total Size: 6.05kB

@codecov
Copy link

codecov bot commented Mar 23, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.37%. Comparing base (d462c1f) to head (30d0226).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #99      +/-   ##
==========================================
+ Coverage   98.34%   98.37%   +0.02%     
==========================================
  Files           8        8              
  Lines         121      123       +2     
  Branches       31       32       +1     
==========================================
+ Hits          119      121       +2     
  Misses          2        2
Files with missing lines Coverage Δ
src/js/crowdin.js 100.00% <100.00%> (ø)

@ReenigneArcher ReenigneArcher merged commit e29de84 into master Mar 23, 2025
12 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/crowdin/expose-initCrowdIn-to-global-scope branch March 23, 2025 01:58
@ReenigneArcher ReenigneArcher mentioned this pull request Mar 23, 2025
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ReenigneArcher