Skip to content

feat: add formatNumber #39

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 1 commit into from
Sep 21, 2024
Merged

feat: add formatNumber #39

ReenigneArcher merged 1 commit into from
Sep 21, 2024

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Sep 21, 2024

Description

Add new function to format numbers in human friendly format.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@codecov
Copy link

codecov bot commented Sep 21, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.55%. Comparing base (6f374ae) to head (6c8035c).
Report is 1 commits behind head on master.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #39      +/-   ##
==========================================
+ Coverage   68.86%   71.55%   +2.68%     
==========================================
  Files           8        9       +1     
  Lines         106      116      +10     
  Branches       20       25       +5     
==========================================
+ Hits           73       83      +10     
  Misses         33       33
Files with missing lines Coverage Δ
src/js/format-number.js 100.00% <100.00%> (ø)

@ReenigneArcher ReenigneArcher enabled auto-merge (squash) September 21, 2024 02:36
@ReenigneArcher ReenigneArcher merged commit 55d87e3 into master Sep 21, 2024
@ReenigneArcher ReenigneArcher deleted the feat/add-formatNumber branch September 21, 2024 02:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ReenigneArcher