fix: do not build docs for external projects #94
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ReenigneArcher
left a comment
ReenigneArcher
left a comment
There was a problem hiding this comment.
Could you make this change to https://github.com/LizardByte/tray as well?
Otherwise, I need to wait to merge this until I can get to that.
Member
|
This might be a hint to the issues with coverage in the this repo. |
Contributor
Author
On MacOS it simply failed to upload... Unless you're talking about something else |
Member
|
That was Linux: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #94 +/- ##
=======================================
Coverage 93.84% 93.84%
=======================================
Files 32 32
Lines 1820 1820
Branches 1014 1014
=======================================
Hits 1708 1708
- Misses 49 58 +9
+ Partials 63 54 -9
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Do not build docs for external projects. Sunshine and libdd are fighting over target names otherwise.
Type of Change
.github/...)Checklist