Skip to content

feat: externalize workarounds for Windows #92

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 6 commits into from
Aug 8, 2024
Merged

feat: externalize workarounds for Windows #92

ReenigneArcher merged 6 commits into from
Aug 8, 2024

Conversation

@FrogTheFrog
Copy link
Contributor

@FrogTheFrog FrogTheFrog commented Aug 8, 2024 •
edited
Loading

Description

Externalize workarounds for Windows.

Currently the HDR workaround for VDD is always applied (for toggling on/off HDR display states), even when VDD is not used and the workaround is probably not needed.
We should allow users to toggle such workarounds as they wish.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

ReenigneArcher
ReenigneArcher reviewed Aug 8, 2024
View reviewed changes
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) August 8, 2024 15:32
@FrogTheFrog FrogTheFrog disabled auto-merge August 8, 2024 15:33
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) August 8, 2024 15:33
@ReenigneArcher ReenigneArcher disabled auto-merge August 8, 2024 15:34
@ReenigneArcher ReenigneArcher enabled auto-merge (squash) August 8, 2024 15:35
@codecov
Copy link

codecov bot commented Aug 8, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.84%. Comparing base (33adf25) to head (9f106e1).
Report is 18 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #92      +/-   ##
==========================================
+ Coverage   93.79%   93.84%   +0.04%     
==========================================
  Files          32       32              
  Lines        1806     1820      +14     
  Branches     1009     1014       +5     
==========================================
+ Hits         1694     1708      +14     
- Misses         49       58       +9     
+ Partials       63       54       -9
Flag Coverage Δ
Linux 89.56% <100.00%> (+0.19%) ⬆️
Windows 93.84% <100.00%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...de/display_device/detail/json_serializer_details.h 100.00% <100.00%> (ø)
src/common/json.cpp 100.00% <100.00%> (ø)
src/windows/json.cpp 100.00% <100.00%> (ø)
src/windows/json_serializer.cpp 100.00% <100.00%> (ø)
src/windows/settings_manager_apply.cpp 99.03% <100.00%> (ø)
src/windows/settings_manager_general.cpp 100.00% <100.00%> (ø)
src/windows/settings_manager_revert.cpp 99.04% <100.00%> (ø)
src/windows/settings_utils.cpp 96.71% <100.00%> (+0.03%) ⬆️
src/windows/types.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit b30c2e1 into LizardByte:master Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ReenigneArcher ReenigneArcher ReenigneArcher left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FrogTheFrog @ReenigneArcher