Skip to content

Conversation

@FrogTheFrog
Copy link
Contributor

Description

Simplify persistence load error handling. Incorrect fallback state could break the assumptions and we don't want that...

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@codecov
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.85%. Comparing base (311f787) to head (9be87aa).

Additional details and impacted files
@@           Coverage Diff           @@
##           master      #69   +/-   ##
=======================================
  Coverage   93.84%   93.85%           
=======================================
  Files          34       34           
  Lines        1837     1838    +1     
  Branches     1021     1021           
=======================================
+ Hits         1724     1725    +1     
- Misses         49       58    +9     
+ Partials       64       55    -9     
Flag Coverage Δ
Linux 89.37% <ø> (ø)
Windows 93.79% <100.00%> (+<0.01%) ⬆️
macOS 69.38% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/windows/persistent_state.cpp 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit 0065c69 into LizardByte:master Jul 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants