Skip to content

Conversation

@FrogTheFrog
Copy link
Contributor

Description

Add file-based persistence handler

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@codecov
Copy link

codecov bot commented Jul 12, 2024

Codecov Report

Attention: Patch coverage is 55.00000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 93.26%. Comparing base (66844be) to head (ecdabad).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #56      +/-   ##
==========================================
- Coverage   94.20%   93.26%   -0.94%     
==========================================
  Files          33       34       +1     
  Lines        1638     1678      +40     
  Branches      916      941      +25     
==========================================
+ Hits         1543     1565      +22     
- Misses         46       61      +15     
- Partials       49       52       +3     
Flag Coverage Δ
Linux 88.20% <55.00%> (-8.57%) ⬇️
Windows 93.23% <55.00%> (-0.95%) ⬇️
macOS 64.76% <34.21%> (-6.75%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...clude/displaydevice/settingspersistenceinterface.h 100.00% <ø> (ø)
src/common/filesettingspersistence.cpp 55.00% <55.00%> (ø)

@FrogTheFrog
Copy link
Contributor Author

Happy with the coverage as I can't test other stuff...

@ReenigneArcher ReenigneArcher merged commit 704295f into LizardByte:master Jul 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants