Skip to content

feat: Add logic for prepping topology and reverting changes #51

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 4 commits into from
Jul 10, 2024
Merged

feat: Add logic for prepping topology and reverting changes #51

ReenigneArcher merged 4 commits into from
Jul 10, 2024

Conversation

@FrogTheFrog
Copy link
Contributor

@FrogTheFrog FrogTheFrog commented Jul 7, 2024

Description

Add logic for prepping topology and reverting changes.

Sorry for the big commit...

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@codecov
Copy link

codecov bot commented Jul 7, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 97.03504% with 11 lines in your changes missing coverage. Please review.

Project coverage is 93.57%. Comparing base (8084b26) to head (4fe847f).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #51      +/-   ##
==========================================
+ Coverage   92.37%   93.57%   +1.20%     
==========================================
  Files          26       33       +7     
  Lines        1101     1478     +377     
  Branches      591      832     +241     
==========================================
+ Hits         1017     1383     +366     
  Misses         46       46              
- Partials       38       49      +11
Flag Coverage Δ
Linux 96.77% <100.00%> (+0.53%) ⬆️
Windows 93.53% <97.01%> (+1.22%) ⬆️
macOS 71.51% <100.00%> (+4.61%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...mmon/include/displaydevice/audiocontextinterface.h 100.00% <ø> (ø)
...rc/common/include/displaydevice/noopaudiocontext.h 100.00% <100.00%> (ø)
...n/include/displaydevice/settingsmanagerinterface.h 100.00% <ø> (ø)
...clude/displaydevice/settingspersistenceinterface.h 100.00% <ø> (ø)
src/common/include/displaydevice/types.h 95.23% <100.00%> (ø)
src/common/json.cpp 100.00% <100.00%> (ø)
src/common/noopaudiocontext.cpp 100.00% <100.00%> (ø)
src/common/noopsettingspersistence.cpp 100.00% <100.00%> (ø)
src/common/types.cpp 100.00% <100.00%> (ø)
src/windows/json.cpp 100.00% <100.00%> (ø)
... and 7 more

@FrogTheFrog
Copy link
Contributor Author

FrogTheFrog commented Jul 7, 2024 •
edited
Loading

Done fixing the coverage. Missing stuff was addressed, what's left now are delusions.

@ReenigneArcher ReenigneArcher merged commit 7c494d7 into LizardByte:master Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FrogTheFrog @ReenigneArcher