Skip to content

Conversation

@FrogTheFrog
Copy link
Contributor

Description

Added a bunch of new interfaces that will have to be implemented little by little.
Also moved the fixture includes due to header name collision.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@codecov
Copy link

codecov bot commented Jun 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.77%. Comparing base (6724842) to head (4886de7).

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #48      +/-   ##
==========================================
+ Coverage   91.56%   91.77%   +0.20%     
==========================================
  Files          13       19       +6     
  Lines        1008     1033      +25     
  Branches      564      571       +7     
==========================================
+ Hits          923      948      +25     
  Misses         46       46              
  Partials       39       39              
Flag Coverage Δ
Linux 93.40% <100.00%> (+0.81%) ⬆️
Windows 91.77% <100.00%> (+0.20%) ⬆️
macOS 58.62% <90.00%> (+4.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...mmon/include/displaydevice/audiocontextinterface.h 100.00% <100.00%> (ø)
...n/include/displaydevice/settingsmanagerinterface.h 100.00% <100.00%> (ø)
...clude/displaydevice/settingspersistenceinterface.h 100.00% <100.00%> (ø)
src/common/noopaudiocontext.cpp 100.00% <100.00%> (ø)
src/common/noopsettingspersistence.cpp 100.00% <100.00%> (ø)
...clude/displaydevice/windows/winapilayerinterface.h 100.00% <ø> (ø)
.../displaydevice/windows/windisplaydeviceinterface.h 100.00% <ø> (ø)
src/windows/settingsmanagergeneral.cpp 100.00% <100.00%> (ø)
src/windows/windisplaydevicegeneral.cpp 100.00% <ø> (ø)

@ReenigneArcher ReenigneArcher merged commit dbceacf into LizardByte:master Jun 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants