Skip to content

feat: add methods for handling hdr state #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 1 commit into from
Jun 10, 2024
Merged

feat: add methods for handling hdr state #45

ReenigneArcher merged 1 commit into from
Jun 10, 2024

Conversation

@FrogTheFrog
Copy link
Contributor

@FrogTheFrog FrogTheFrog commented Jun 10, 2024

Description

Add methods for handling HDR state.

I predict that sadly the coverage might go down a little :/...

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@codecov
Copy link

codecov bot commented Jun 10, 2024

Codecov Report

Attention: Patch coverage is 95.12195% with 4 lines in your changes missing coverage. Please review.

Project coverage is 91.44%. Comparing base (5f960ed) to head (a4f35ec).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #45      +/-   ##
==========================================
- Coverage   91.46%   91.44%   -0.02%     
==========================================
  Files           4       13       +9     
  Lines          82      935     +853     
  Branches       41      523     +482     
==========================================
+ Hits           75      855     +780     
- Misses          4       43      +39     
- Partials        3       37      +34
Flag Coverage Δ
Linux 92.59% <ø> (ø)
Windows 91.44% <95.12%> (?)
macOS 54.54% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
...clude/displaydevice/windows/winapilayerinterface.h 100.00% <ø> (ø)
.../displaydevice/windows/windisplaydeviceinterface.h 100.00% <ø> (ø)
src/windows/windisplaydevicehdr.cpp 100.00% <100.00%> (ø)
src/windows/winapilayer.cpp 78.19% <83.33%> (ø)

... and 5 files with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit f770754 into LizardByte:master Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FrogTheFrog @ReenigneArcher