Skip to content

ci: fix code coverage #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 1 commit into from
May 7, 2024
Merged

ci: fix code coverage #25

ReenigneArcher merged 1 commit into from
May 7, 2024

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented May 7, 2024 •
edited
Loading

Description

Fix coverage reports after #17 inadvertently re-ordered some things related to coverage.

Screenshot

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher force-pushed the ci-fix-code-coverage branch 4 times, most recently from 4ae4100 to e0d71db Compare May 7, 2024 18:38
@ReenigneArcher ReenigneArcher mentioned this pull request May 7, 2024
Merged
11 tasks
@ReenigneArcher ReenigneArcher force-pushed the ci-fix-code-coverage branch from e0d71db to a079cb5 Compare May 7, 2024 19:57
@codecov
Copy link

codecov bot commented May 7, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

❗ No coverage uploaded for pull request base (master@8fa9d69). Click here to learn what that means.

Additional details and impacted files 
@@            Coverage Diff            @@
##             master      #25   +/-   ##
=========================================
  Coverage          ?   44.75%           
=========================================
  Files             ?        7           
  Lines             ?      324           
  Branches          ?      177           
=========================================
  Hits              ?      145           
  Misses            ?       42           
  Partials          ?      137
Flag Coverage Δ
Linux 63.82% <ø> (?)
Windows 44.29% <ø> (?)
macOS 51.66% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ReenigneArcher ReenigneArcher force-pushed the ci-fix-code-coverage branch from a079cb5 to a6e8547 Compare May 7, 2024 21:23
@ReenigneArcher ReenigneArcher marked this pull request as ready for review May 7, 2024 22:19
@ReenigneArcher ReenigneArcher force-pushed the ci-fix-code-coverage branch from a6e8547 to 88ce4ff Compare May 7, 2024 22:26
@ReenigneArcher ReenigneArcher merged commit 3e79da9 into master May 7, 2024
@ReenigneArcher ReenigneArcher deleted the ci-fix-code-coverage branch May 7, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ReenigneArcher