feat: WinDisplayDeviceInterface and first const topology methods #24
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #24 +/- ##
==========================================
+ Coverage 69.25% 74.87% +5.61%
==========================================
Files 6 11 +5
Lines 309 394 +85
Branches 177 221 +44
==========================================
+ Hits 214 295 +81
+ Misses 39 38 -1
- Partials 56 61 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
|
FrogTheFrog
force-pushed
the
master
branch
4 times, most recently
from
e2a5fe4 to
5cebfb8
Compare
| // local includes | ||
| #include "mockwinapilayer.h" | ||
|
|
||
| namespace { |
There was a problem hiding this comment.
I am not familiar with gmock, but is there a way to parametrize these?
There was a problem hiding this comment.
I'm not sure I follow? I have defined these const's to be reusable within the first UT and future UTs.
There was a problem hiding this comment.
If you meant TEST_P, I have decided against it, since it requires it's own test fixture and the data set is just too small where it is usable to justify creating for a single function.
In other places the EXPECT_CALL is too different for most cases, so it would be hard to parametrize it properly.
FrogTheFrog
force-pushed
the
master
branch
3 times, most recently
from
31739d2 to
abd45ae
Compare
|
I've fixed the issue with coverage in the ci. You can revert your last commit (also not sure we need the |
2 participants
Description
Implemented the first topology methods, yay!
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.