feat: Initial WinApiLayer with some methods #15
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment was marked as resolved.
This comment was marked as resolved.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #15 +/- ##
===========================================
- Coverage 67.34% 45.45% -21.90%
===========================================
Files 2 5 +3
Lines 49 154 +105
Branches 17 89 +72
===========================================
+ Hits 33 70 +37
- Misses 2 7 +5
- Partials 14 77 +63
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
ReenigneArcher
left a comment
ReenigneArcher
left a comment
There was a problem hiding this comment.
I think the coverage results are a little inaccurate. Trying to work through that for Sunshine as well in gcovr/gcovr#915
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added the initial WinApiLayer that will act as the final layer between the code and OS.
WinApiLayer will have some basic testing, but not all code paths will be verified as it will be pain in the a** to mock the dreadful WinAPI...
Also applied some suggestions from CLion regarding
consts.Finally, removed this preamble:
Please, let's not use it in this library as it is the most useless thing and I hate it :'( . It always boils down to this description:
"filename.cpp" -> "Implements the class/functions"
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.