fix(enumAvailableDevices): exception when enumerating #146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #146 +/- ##
=======================================
Coverage 93.22% 93.22%
=======================================
Files 34 34
Lines 2124 2124
Branches 1085 1085
=======================================
Hits 1980 1980
- Misses 75 82 +7
+ Partials 69 62 -7
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed a stupid assumption that source id
0is always available, instead we now fallback to first source id.The test data set was also updated to non-zero ids, which reproduced the crash, however with the fix all tests are green again.
Issues Fixed or Closed
Should fix the Sunshine crash in LizardByte/Sunshine#3770
Type of Change
.github/...)Checklist