Skip to content

feat: add basic EDID information during device enumeration #139

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 6 commits into from
Feb 1, 2025
Merged

feat: add basic EDID information during device enumeration #139

ReenigneArcher merged 6 commits into from
Feb 1, 2025

Conversation

@FrogTheFrog
Copy link
Contributor

@FrogTheFrog FrogTheFrog commented Feb 1, 2025

Description

Added basic EDID fields to the enumerated devices: manufacturer id, product code and serial number.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@codecov
Copy link

codecov bot commented Feb 1, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 84.48276% with 18 lines in your changes missing coverage. Please review.

Project coverage is 93.20%. Comparing base (53a0ea5) to head (0e003ef).
Report is 9 commits behind head on master.

Files with missing lines Patch % Lines
src/windows/win_api_layer.cpp 69.64% 10 Missing and 7 partials ⚠️
src/common/types.cpp 98.03% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #139      +/-   ##
==========================================
+ Coverage   93.15%   93.20%   +0.05%     
==========================================
  Files          34       34              
  Lines        2044     2118      +74     
  Branches     1054     1085      +31     
==========================================
+ Hits         1904     1974      +70     
- Misses         81       82       +1     
- Partials       59       62       +3
Flag Coverage Δ
Linux 93.65% <98.07%> (+0.66%) ⬆️
Windows 92.97% <83.48%> (+0.03%) ⬆️
macOS 74.09% <74.57%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/common/include/display_device/types.h 96.55% <100.00%> (+0.71%) ⬆️
src/common/json.cpp 100.00% <100.00%> (ø)
src/common/json_serializer.cpp 100.00% <100.00%> (ø)
...e/display_device/windows/win_api_layer_interface.h 100.00% <ø> (ø)
src/windows/win_display_device_general.cpp 100.00% <100.00%> (ø)
src/common/types.cpp 98.63% <98.03%> (-1.37%) ⬇️
src/windows/win_api_layer.cpp 74.44% <69.64%> (+0.28%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Feb 1, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
13 New issues
5.2% Duplication on New Code (required ≤ 2%)
13 New Code Smells (required ≤ 0)
4 Duplicated Blocks on New Code (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@FrogTheFrog

This comment was marked as outdated.

Sign in to view
@FrogTheFrog FrogTheFrog marked this pull request as ready for review February 1, 2025 15:31
@ReenigneArcher ReenigneArcher merged commit 41914d0 into LizardByte:master Feb 1, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FrogTheFrog @ReenigneArcher