Skip to content

fix(hdr): use new HDR WinAPI for W11 24H2 and above #137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 1 commit into from
Jan 26, 2025
Merged

fix(hdr): use new HDR WinAPI for W11 24H2 and above #137

ReenigneArcher merged 1 commit into from
Jan 26, 2025

Conversation

@FrogTheFrog
Copy link
Contributor

@FrogTheFrog FrogTheFrog commented Jan 26, 2025

Description

Use new HDR WinAPI for W11 24H2 and above

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 26, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
2 New issues
2 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@codecov
Copy link

codecov bot commented Jan 26, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 31.57895% with 26 lines in your changes missing coverage. Please review.

Project coverage is 93.11%. Comparing base (1975f75) to head (92ac760).
Report is 10 commits behind head on master.

Files with missing lines Patch % Lines
src/windows/win_api_layer.cpp 31.57% 23 Missing and 3 partials ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #137      +/-   ##
==========================================
- Coverage   94.28%   93.11%   -1.17%     
==========================================
  Files          34       34              
  Lines        2011     2049      +38     
  Branches     1040     1057      +17     
==========================================
+ Hits         1896     1908      +12     
- Misses         51       74      +23     
- Partials       64       67       +3
Flag Coverage Δ
Linux 92.98% <ø> (ø)
Windows 92.90% <31.57%> (-1.20%) ⬇️
macOS 74.15% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/windows/win_api_layer.cpp 73.90% <31.57%> (-4.61%) ⬇️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@ReenigneArcher ReenigneArcher merged commit f434ff2 into LizardByte:master Jan 26, 2025
20 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FrogTheFrog @ReenigneArcher