Skip to content

chore: update global workflows #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 2 commits into from
Jan 20, 2025
Merged

chore: update global workflows #134

ReenigneArcher merged 2 commits into from
Jan 20, 2025

Conversation

@LizardByte-bot
Copy link
Member

@LizardByte-bot LizardByte-bot commented Jan 20, 2025

No description provided.

@codecov
Copy link

codecov bot commented Jan 20, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 95.81673% with 21 lines in your changes missing coverage. Please review.

Project coverage is 94.28%. Comparing base (63599b0) to head (f5199bc).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
src/windows/win_api_layer.cpp 86.36% 3 Missing and 6 partials ⚠️
src/windows/settings_utils.cpp 91.22% 0 Missing and 5 partials ⚠️
src/common/file_settings_persistence.cpp 81.81% 2 Missing ⚠️
...rc/common/include/display_device/retry_scheduler.h 95.74% 0 Missing and 2 partials ⚠️
src/windows/settings_manager_apply.cpp 98.30% 0 Missing and 1 partial ⚠️
src/windows/win_api_utils.cpp 98.03% 0 Missing and 1 partial ⚠️
src/windows/win_display_device_topology.cpp 95.45% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
- Coverage   94.30%   94.28%   -0.02%     
==========================================
  Files          34       34              
  Lines        2018     2011       -7     
  Branches     1041     1040       -1     
==========================================
- Hits         1903     1896       -7     
- Misses         51       58       +7     
+ Partials       64       57       -7
Flag Coverage Δ
Linux 92.98% <96.26%> (-0.05%) ⬇️
Windows 94.10% <95.52%> (-0.03%) ⬇️
macOS 74.15% <73.50%> (-0.92%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...n/include/display_device/audio_context_interface.h 100.00% <ø> (ø)
...mon/include/display_device/detail/json_converter.h 100.00% <100.00%> (ø)
...de/display_device/detail/json_serializer_details.h 100.00% <100.00%> (ø)
src/common/include/display_device/logging.h 100.00% <100.00%> (ø)
...common/include/display_device/noop_audio_context.h 100.00% <ø> (ø)
...nclude/display_device/settings_manager_interface.h 100.00% <ø> (ø)
...de/display_device/settings_persistence_interface.h 100.00% <ø> (ø)
src/common/include/display_device/types.h 95.83% <ø> (ø)
src/common/json_serializer.cpp 100.00% <100.00%> (ø)
src/common/logging.cpp 95.52% <100.00%> (ø)
... and 22 more
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 20, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
201 New issues
201 New Code Smells (required ≤ 0)
B Maintainability Rating on New Code (required ≥ A)
9 Duplicated Blocks on New Code (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@ReenigneArcher ReenigneArcher merged commit d6fa6cf into master Jan 20, 2025
21 of 22 checks passed
@ReenigneArcher ReenigneArcher deleted the bot/update-files-from-global-repo branch January 20, 2025 20:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@LizardByte-bot @ReenigneArcher