Skip to content

feat(settings_revert): use full extended topology as a fallback #133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 5 commits into from
Jan 15, 2025
Merged

feat(settings_revert): use full extended topology as a fallback #133

ReenigneArcher merged 5 commits into from
Jan 15, 2025

Conversation

@FrogTheFrog
Copy link
Contributor

@FrogTheFrog FrogTheFrog commented Jan 15, 2025

Description

Use full extended topology as a fallback. This increases the chances of use actually having a proper display!

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@CLAassistant
Copy link

CLAassistant commented Jan 15, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@FrogTheFrog FrogTheFrog force-pushed the different-recovery-state branch from b237b76 to bbc01be Compare January 15, 2025 07:56
@codecov
Copy link

codecov bot commented Jan 15, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.55172% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.30%. Comparing base (2c431bc) to head (88fc147).
Report is 16 commits behind head on master.

Files with missing lines Patch % Lines
src/windows/settings_utils.cpp 83.33% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #133      +/-   ##
==========================================
- Coverage   94.34%   94.30%   -0.05%     
==========================================
  Files          34       34              
  Lines        2015     2018       +3     
  Branches     1041     1041              
==========================================
+ Hits         1901     1903       +2     
- Misses         51       58       +7     
+ Partials       63       57       -6
Flag Coverage Δ
Linux 93.03% <ø> (+1.81%) ⬆️
Windows 94.12% <96.55%> (-0.05%) ⬇️
macOS 75.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...nclude/display_device/settings_manager_interface.h 100.00% <ø> (ø)
src/windows/settings_manager_apply.cpp 99.07% <100.00%> (ø)
src/windows/settings_manager_general.cpp 100.00% <100.00%> (ø)
src/windows/settings_manager_revert.cpp 98.26% <100.00%> (ø)
src/windows/win_api_layer.cpp 78.87% <100.00%> (ø)
src/windows/settings_utils.cpp 96.53% <83.33%> (-0.40%) ⬇️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Jan 15, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
8.7% Duplication on New Code (required ≤ 2%)
4 Duplicated Blocks on New Code (required ≤ 0)

See analysis details on SonarQube Cloud

@ReenigneArcher ReenigneArcher merged commit cba45e3 into LizardByte:master Jan 15, 2025
21 of 22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@FrogTheFrog @CLAassistant @ReenigneArcher