Skip to content

fix(boost): do not link to ALIAS target #128

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 4 commits into from
Dec 17, 2024
Merged

fix(boost): do not link to ALIAS target #128

ReenigneArcher merged 4 commits into from
Dec 17, 2024

Conversation

@FrogTheFrog
Copy link
Contributor

@FrogTheFrog FrogTheFrog commented Dec 17, 2024 •
edited
Loading

Description

Fixes incorrect dep. target linking issues in some cases.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@github-advanced-security

This comment was marked as duplicate.

Sign in to view
@codecov
Copy link

codecov bot commented Dec 17, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.34%. Comparing base (bbcd179) to head (9f24ca7).
Report is 16 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #128   +/-   ##
=======================================
  Coverage   94.34%   94.34%           
=======================================
  Files          34       34           
  Lines        2015     2015           
  Branches     1041     1041           
=======================================
  Hits         1901     1901           
+ Misses         51       49    -2     
- Partials       63       65    +2
Flag Coverage Δ
Linux 91.21% <ø> (ø)
Windows 94.17% <ø> (ø)
macOS 75.06% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

see 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@FrogTheFrog FrogTheFrog changed the title feat(boost): bump to 1.87 fix(boost): do not link to ALIAS target Dec 17, 2024
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ReenigneArcher ReenigneArcher enabled auto-merge (squash) December 17, 2024 13:41
@ReenigneArcher ReenigneArcher merged commit bc7ea1f into LizardByte:master Dec 17, 2024
22 checks passed
@FrogTheFrog FrogTheFrog deleted the patch-1 branch December 17, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ReenigneArcher ReenigneArcher ReenigneArcher approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FrogTheFrog @ReenigneArcher