fix: unstable timed thread tests #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrogTheFrog
commented
Nov 16, 2024
| } | ||
|
|
||
| EXPECT_GE(first_call_delay, 0); | ||
| EXPECT_GE(first_call_delay, roundTo99(0)); |
Contributor
Author
There was a problem hiding this comment.
Added call here just for consistency even if it's still 0 in the end
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #126 +/- ##
=======================================
Coverage 94.34% 94.34%
=======================================
Files 34 34
Lines 2015 2015
Branches 1041 1041
=======================================
Hits 1901 1901
+ Misses 51 49 -2
- Partials 63 65 +2
Flags with carried forward coverage won't be shown. Click here to find out more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Lowered the lower bound by 1% for tests that are verifying that the thread has woken up within the expected time frame. They ideally should wake up on the lower bound delay, but sometime they wake up a little earlier.
Type of Change
.github/...)Checklist