fix: topology not always reverted back after reverting settings #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #125 +/- ##
==========================================
- Coverage 94.38% 94.34% -0.04%
==========================================
Files 34 34
Lines 2011 2015 +4
Branches 1039 1041 +2
==========================================
+ Hits 1898 1901 +3
+ Misses 58 51 -7
- Partials 55 63 +8
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
If the user manually switches back to the initial display topology and then reverts the settings, we would switch to the modified topology to undo stuff, but then never switch back to the initial topology matched the current one.
We are now smart enough to actually go "hmm, if current_topology == initial_topology, but then I switch to modified_topology, then current_topology != initial_topology after that! Me thinks thou should switch back'o to the ini_topo!" (yes, I'm losing sanity here)...
Type of Change
.github/...)Checklist