Skip to content

fix: execute auto deduction and copyable stop token #120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 2 commits into from
Oct 26, 2024
Merged

fix: execute auto deduction and copyable stop token #120

ReenigneArcher merged 2 commits into from
Oct 26, 2024

Conversation

@FrogTheFrog
Copy link
Contributor

@FrogTheFrog FrogTheFrog commented Oct 26, 2024

Description

This fixes the broken auto deduction for lambdas introduced by #119 and also makes the stop token no longer copyable (it still worked out of pure luck before...).

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
22 New issues
22 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@codecov
Copy link

codecov bot commented Oct 26, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 96.42857% with 1 line in your changes missing coverage. Please review.

Project coverage is 94.38%. Comparing base (24424ac) to head (2559319).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
...rc/common/include/display_device/retry_scheduler.h 96.42% 0 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #120      +/-   ##
==========================================
+ Coverage   94.36%   94.38%   +0.01%     
==========================================
  Files          34       34              
  Lines        2005     2011       +6     
  Branches     1038     1039       +1     
==========================================
+ Hits         1892     1898       +6     
  Misses         58       58              
  Partials       55       55
Flag Coverage Δ
Linux 91.21% <96.00%> (+0.13%) ⬆️
Windows 94.21% <96.00%> (+0.01%) ⬆️
macOS 75.06% <82.14%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/common/include/display_device/retry_scheduler.h 97.22% <96.42%> (+0.16%) ⬆️

@ReenigneArcher ReenigneArcher merged commit 0145bfe into LizardByte:master Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FrogTheFrog @ReenigneArcher