Skip to content

fix: downgrade to gcc 11 #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 3 commits into from
Apr 17, 2024
Merged

fix: downgrade to gcc 11 #12

ReenigneArcher merged 3 commits into from
Apr 17, 2024

Conversation

@FrogTheFrog
Copy link
Contributor

@FrogTheFrog FrogTheFrog commented Apr 17, 2024

Description

Remove the usage of std::format to reduce GCC to V11.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@codecov
Copy link

codecov bot commented Apr 17, 2024 •
edited
Loading

Codecov Report

Attention: Patch coverage is 16.66667% with 5 lines in your changes are missing coverage. Please review.

Project coverage is 67.34%. Comparing base (d8fd81d) to head (c980074).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master      #12      +/-   ##
==========================================
- Coverage   70.21%   67.34%   -2.87%     
==========================================
  Files           2        2              
  Lines          47       49       +2     
  Branches       15       17       +2     
==========================================
  Hits           33       33              
- Misses          1        2       +1     
- Partials       13       14       +1
Flag Coverage Δ
Windows 67.34% <16.66%> (-2.87%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
src/logging.cpp 68.08% <16.66%> (-3.03%) ⬇️

@ReenigneArcher
Copy link
Member

ReenigneArcher commented Apr 17, 2024

@cgutman As discussed in LizardByte/Sunshine#2032 this repo will be a library for the majority of the code in that PR. When I fixed the CodeQL builds to support different OSes, it was discovered that std::format is not available unless using gcc 13.

Initially this library will be Windows only, but I think there is an opportunity to add Linux support as well. How opposed would you be to moving to gcc 13 for Sunshine Linux builds (if/when this library adds Linux support)? It would require a newer CUDA version, thus dropping support for some older GPUs.

@FrogTheFrog
Copy link
Contributor Author

FrogTheFrog commented Apr 17, 2024

@ReenigneArcher

I will probably not use std::format again so it's not an issue for me (for now)

@ReenigneArcher ReenigneArcher merged commit 8605aab into LizardByte:master Apr 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FrogTheFrog @ReenigneArcher