Skip to content

feat: add const version of RetryScheduler::execute #119

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 4 commits into from
Oct 26, 2024
Merged

feat: add const version of RetryScheduler::execute #119

ReenigneArcher merged 4 commits into from
Oct 26, 2024

Conversation

@FrogTheFrog
Copy link
Contributor

@FrogTheFrog FrogTheFrog commented Oct 25, 2024

Description

Adds a const variant of RetryScheduler::execute...

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@codecov
Copy link

codecov bot commented Oct 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.36%. Comparing base (43feb4e) to head (8cde9bd).
Report is 14 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master     #119   +/-   ##
=======================================
  Coverage   94.35%   94.36%           
=======================================
  Files          34       34           
  Lines        2003     2005    +2     
  Branches     1038     1038           
=======================================
+ Hits         1890     1892    +2     
+ Misses         58       51    -7     
- Partials       55       62    +7
Flag Coverage Δ
Linux 91.07% <100.00%> (+0.05%) ⬆️
Windows 94.19% <100.00%> (+<0.01%) ⬆️
macOS 74.93% <100.00%> (+0.13%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/common/include/display_device/retry_scheduler.h 97.05% <100.00%> (+0.05%) ⬆️

... and 1 file with indirect coverage changes

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
8 New issues
8 New Code Smells (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@ReenigneArcher ReenigneArcher merged commit 24424ac into LizardByte:master Oct 26, 2024
@FrogTheFrog FrogTheFrog mentioned this pull request Oct 26, 2024
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FrogTheFrog @ReenigneArcher