Skip to content

feat(RetryScheduler): add more options for scheduling executor #115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 4 commits into from
Oct 13, 2024
Merged

feat(RetryScheduler): add more options for scheduling executor #115

ReenigneArcher merged 4 commits into from
Oct 13, 2024

Conversation

@FrogTheFrog
Copy link
Contributor

@FrogTheFrog FrogTheFrog commented Oct 6, 2024

Description

Added more options for scheduling the executor function.

It is a breaking change in a sense that function call has to be adapted, so I dunno if it still counts...

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

@FrogTheFrog FrogTheFrog marked this pull request as draft October 6, 2024 11:32
@FrogTheFrog FrogTheFrog marked this pull request as ready for review October 6, 2024 12:24
@ReenigneArcher
Copy link
Member

ReenigneArcher commented Oct 7, 2024

I need to fix the coverage before this gets merged. Sorry.

@ReenigneArcher
Copy link
Member

ReenigneArcher commented Oct 12, 2024 •
edited
Loading

I tried fixing coverage in #117, but it's still not working.

On codecov I see this, only for macOS.

image

I believe this is ultimately some issue with gcovr.

https://github.com/LizardByte/libdisplaydevice/actions/runs/11308010612/job/31450387472#step:11:75

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 13, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
18 New issues
29.0% Duplication on New Code (required ≤ 2%)
18 New Code Smells (required ≤ 0)
3 Duplicated Blocks on New Code (required ≤ 0)

See analysis details on SonarCloud

Catch issues before they fail your Quality Gate with our IDE extension SonarLint

@codecov
Copy link

codecov bot commented Oct 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.35%. Comparing base (3372bf8) to head (65ca27f).
Report is 9 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #115      +/-   ##
==========================================
+ Coverage   94.31%   94.35%   +0.04%     
==========================================
  Files          34       34              
  Lines        1988     2003      +15     
  Branches     1029     1038       +9     
==========================================
+ Hits         1875     1890      +15     
+ Misses         51       49       -2     
- Partials       62       64       +2
Flag Coverage Δ
Linux 91.02% <100.00%> (+0.37%) ⬆️
Windows 94.19% <100.00%> (+0.04%) ⬆️
macOS 74.79% <76.92%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
...rc/common/include/display_device/retry_scheduler.h 97.00% <100.00%> (+0.52%) ⬆️

... and 1 file with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit 43feb4e into LizardByte:master Oct 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@FrogTheFrog @ReenigneArcher