fix(release_homebrew): ignore indented version lines in formula blocks during version extraction #98
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s during version extraction The extract_version_from_formula function was incorrectly picking up version declarations inside blocks like fails_with instead of the main formula version. Updated the logic to only consider version lines at class level (2-space indentation) and ignore those in deeper blocks (4+ spaces). Added tests to verify the behavior.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #98 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 6 6
Lines 979 979
Branches 82 82
=========================================
Hits 979 979
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The extract_version_from_formula function was incorrectly picking up version declarations inside blocks like fails_with instead of the main formula version. Updated the logic to only consider version lines at class level (2-space indentation) and ignore those in deeper blocks (4+ spaces). Added tests to verify the behavior.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage