Skip to content

fix(release_homebrew): fix empty outputs when validate is false #97

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 1 commit into from
Dec 24, 2025
Merged

fix(release_homebrew): fix empty outputs when validate is false #97

ReenigneArcher merged 1 commit into from
Dec 24, 2025

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Dec 24, 2025

Description

When validate: false was specified it would lead to empty step outputs which were required for later steps in the composite action.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov
Copy link

codecov bot commented Dec 24, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (4586d79) to head (f61e907).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@            Coverage Diff            @@
##            master       #97   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            6         6           
  Lines          979       979           
  Branches        82        82           
=========================================
  Hits           979       979
Flag Coverage Δ
Linux 100.00% <100.00%> (ø)
Windows 76.60% <100.00%> (+0.10%) ⬆️
macOS 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
actions/release_homebrew/main.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ReenigneArcher ReenigneArcher force-pushed the fix/release_homebrew/fix-publishing branch 2 times, most recently from 54a2bac to 1e73636 Compare December 24, 2025 14:46
@ReenigneArcher ReenigneArcher force-pushed the fix/release_homebrew/fix-publishing branch from 1e73636 to f61e907 Compare December 24, 2025 15:02
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 24, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ReenigneArcher ReenigneArcher marked this pull request as ready for review December 24, 2025 15:19
@ReenigneArcher ReenigneArcher merged commit 20ea35f into master Dec 24, 2025
70 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/release_homebrew/fix-publishing branch December 24, 2025 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ReenigneArcher