-
-
Notifications
You must be signed in to change notification settings - Fork 0
feat(release_homebrew): bring tests to parity with official homebrew workflows #80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(release_homebrew): bring tests to parity with official homebrew workflows #80
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #80 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 6 6
Lines 820 979 +159
Branches 82 82
==========================================
+ Hits 820 979 +159
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
7659de3 to
11ac390
Compare
205f0b0 to
ec15e02
Compare
This comment was marked as resolved.
This comment was marked as resolved.
6da86b8 to
122e251
Compare
b66957e to
73ef9fe
Compare
Refactors the release_homebrew action to improve tap handling, commit logic, and GitHub Actions log grouping. Adds robust tap name parsing, explicit commit steps for formula changes, and more granular test-bot steps. Updates tests and fixtures for better coverage, including tap naming edge cases, environment setup, and cleanup. Introduces .gitattributes for consistent line endings and improves CI workflow reliability, especially on macOS.
a33f713 to
b9742eb
Compare
Refactored the action and main script to allow specifying custom head and base branches for both the org homebrew repo and homebrew-core fork when creating pull requests. Updated documentation and input parameters to reflect these changes. Enhanced test coverage to validate the new branch handling logic.
dc43d6c to
d25ad97
Compare
Enhanced the test_process_input_formula_copy_failure test by mocking os.makedirs and shutil.copy2 to simulate directory creation and file copying. This ensures the test accurately simulates a copy failure scenario without performing actual file operations.
d25ad97 to
ee3c2e9
Compare
Updated the release_homebrew action to generate commit messages based on whether a formula is new or updated, and to include the version number when available. The commit message is now set as an output and used in subsequent commit and pull request steps, replacing the previous static message format.
Extracted formula version extraction, commit message generation, formula tracking, and file copying into separate functions in main.py for better modularity and testability. Added comprehensive unit tests for these new functions in test_release_homebrew.py, improving code coverage and reliability.
19090b4 to
b74dddf
Compare
Introduces a new input, skip_stable_version_audit, to the release_homebrew action to optionally skip the stable version audit in brew test-bot runs. Updates the README, action.yml, and main.py to support this feature, and sets the default to true for easier PR testing. Minor whitespace fixes in test_release_homebrew.py.
29b5ed7 to
222dd3c
Compare
Introduces the Homebrew/actions/setup-homebrew action for consistent Homebrew environment setup. Removes manual PATH configuration and streamlines the Homebrew test step.
222dd3c to
67c2085
Compare
Adds the HOMEBREW_BOTTLE_BUILD environment variable when running the Homebrew test bot to allow skipping advanced tests during bottle builds. This change ensures the subprocess inherits the current environment and sets the required variable.
|



Description
Use
brew test-botfor testing formulas.TODO:
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage