Skip to content

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Dec 8, 2025

Description

Use brew test-bot for testing formulas.

TODO:

  • use org tap instead of creating new temporary tap
  • audit using brew test-bot
  • build bottles using brew test-bot
  • publish formulas via PR instead of direct push
    • auto label PRs from our bot with pr-pull after PR checks pass

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov
Copy link

codecov bot commented Dec 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (3a6943b) to head (c9c8e32).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##            master       #80    +/-   ##
==========================================
  Coverage   100.00%   100.00%            
==========================================
  Files            6         6            
  Lines          820       979   +159     
  Branches        82        82            
==========================================
+ Hits           820       979   +159     
Flag Coverage Δ
Linux 100.00% <100.00%> (ø)
Windows 76.50% <35.29%> (-6.55%) ⬇️
macOS 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
actions/release_homebrew/main.py 100.00% <100.00%> (ø)
🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@ReenigneArcher ReenigneArcher force-pushed the feat/release_homebrew/bring-tests-to-parity-with-official-homebrew-workflows branch 11 times, most recently from 7659de3 to 11ac390 Compare December 9, 2025 00:53
@ReenigneArcher ReenigneArcher force-pushed the feat/release_homebrew/bring-tests-to-parity-with-official-homebrew-workflows branch 15 times, most recently from 205f0b0 to ec15e02 Compare December 12, 2025 18:23
@ReenigneArcher

This comment was marked as resolved.

@ReenigneArcher ReenigneArcher force-pushed the feat/release_homebrew/bring-tests-to-parity-with-official-homebrew-workflows branch from 6da86b8 to 122e251 Compare December 16, 2025 01:39
@ReenigneArcher ReenigneArcher force-pushed the feat/release_homebrew/bring-tests-to-parity-with-official-homebrew-workflows branch 5 times, most recently from b66957e to 73ef9fe Compare December 17, 2025 03:37
@ReenigneArcher ReenigneArcher marked this pull request as ready for review December 17, 2025 03:55
Refactors the release_homebrew action to improve tap handling, commit logic, and GitHub Actions log grouping. Adds robust tap name parsing, explicit commit steps for formula changes, and more granular test-bot steps. Updates tests and fixtures for better coverage, including tap naming edge cases, environment setup, and cleanup. Introduces .gitattributes for consistent line endings and improves CI workflow reliability, especially on macOS.
@ReenigneArcher ReenigneArcher force-pushed the feat/release_homebrew/bring-tests-to-parity-with-official-homebrew-workflows branch 3 times, most recently from a33f713 to b9742eb Compare December 17, 2025 23:49
Refactored the action and main script to allow specifying custom head and base branches for both the org homebrew repo and homebrew-core fork when creating pull requests. Updated documentation and input parameters to reflect these changes. Enhanced test coverage to validate the new branch handling logic.
@ReenigneArcher ReenigneArcher force-pushed the feat/release_homebrew/bring-tests-to-parity-with-official-homebrew-workflows branch 2 times, most recently from dc43d6c to d25ad97 Compare December 18, 2025 00:39
Enhanced the test_process_input_formula_copy_failure test by mocking os.makedirs and shutil.copy2 to simulate directory creation and file copying. This ensures the test accurately simulates a copy failure scenario without performing actual file operations.
@ReenigneArcher ReenigneArcher force-pushed the feat/release_homebrew/bring-tests-to-parity-with-official-homebrew-workflows branch from d25ad97 to ee3c2e9 Compare December 18, 2025 01:08
Updated the release_homebrew action to generate commit messages based on whether a formula is new or updated, and to include the version number when available. The commit message is now set as an output and used in subsequent commit and pull request steps, replacing the previous static message format.
Extracted formula version extraction, commit message generation, formula tracking, and file copying into separate functions in main.py for better modularity and testability. Added comprehensive unit tests for these new functions in test_release_homebrew.py, improving code coverage and reliability.
@ReenigneArcher ReenigneArcher force-pushed the feat/release_homebrew/bring-tests-to-parity-with-official-homebrew-workflows branch 2 times, most recently from 19090b4 to b74dddf Compare December 19, 2025 02:17
Introduces a new input, skip_stable_version_audit, to the release_homebrew action to optionally skip the stable version audit in brew test-bot runs. Updates the README, action.yml, and main.py to support this feature, and sets the default to true for easier PR testing. Minor whitespace fixes in test_release_homebrew.py.
@ReenigneArcher ReenigneArcher force-pushed the feat/release_homebrew/bring-tests-to-parity-with-official-homebrew-workflows branch 3 times, most recently from 29b5ed7 to 222dd3c Compare December 19, 2025 03:06
Introduces the Homebrew/actions/setup-homebrew action for consistent Homebrew environment setup. Removes manual PATH configuration and streamlines the Homebrew test step.
@ReenigneArcher ReenigneArcher force-pushed the feat/release_homebrew/bring-tests-to-parity-with-official-homebrew-workflows branch from 222dd3c to 67c2085 Compare December 19, 2025 03:14
Adds the HOMEBREW_BOTTLE_BUILD environment variable when running the Homebrew test bot to allow skipping advanced tests during bottle builds. This change ensures the subprocess inherits the current environment and sets the required variable.
@sonarqubecloud
Copy link

@ReenigneArcher ReenigneArcher merged commit 9f62c5e into master Dec 19, 2025
116 of 118 checks passed
@ReenigneArcher ReenigneArcher deleted the feat/release_homebrew/bring-tests-to-parity-with-official-homebrew-workflows branch December 19, 2025 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants