refactor: release_changelog and release_create actions to use modular scripts #47
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #47 +/- ##
==========================================
Coverage 100.00% 100.00%
==========================================
Files 4 6 +2
Lines 620 798 +178
Branches 57 79 +22
==========================================
+ Hits 620 798 +178
Flags with carried forward coverage won't be shown. Click here to find out more.
|
… scripts Moved inline scripts in release_changelog and release_create actions to separate JavaScript modules (changelog.js and cleanup.js) for better maintainability and testability. Added comprehensive unit tests for both modules. This refactor improves code organization and enables easier testing and future enhancements.
ReenigneArcher
force-pushed
the
refactor/modular-js-scripts
branch
from
104abd5 to
18aac2a
Compare
Extracted common mock and console setup logic into a new tests/testUtils.js utility module. Updated test_changelog.test.js and test_cleanup.test.js to use these shared utilities, reducing duplication and improving maintainability.
ReenigneArcher
force-pushed
the
refactor/modular-js-scripts
branch
from
8063710 to
4d66ec8
Compare
Replaces manual release object construction in tests with new createMockRelease and createMockReleases helpers for consistency and reduced duplication. Adds these helper functions to testUtils.js and updates all relevant test files to use them.
Introduces helper functions in testUtils.js for setting up and verifying branch creation and delete operations in tests. Updates release_changelog and release_create test suites to use these helpers, reducing duplication and improving readability.
Added setupCleanupEnv and setupChangelogWorkflow utility functions to centralize environment variable and mock setup in tests. Updated release changelog and cleanup tests to use these new utilities, improving readability and maintainability. Broadened ESLint Jest config to include all test JS files.
ReenigneArcher
force-pushed
the
refactor/modular-js-scripts
branch
3 times, most recently
from
bd7c251 to
7c3ce6b
Compare
Consolidated multiple individual tests for compareVersionTags into a single parameterized test using test.each, improving test maintainability and reducing code duplication.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Moved inline scripts in release_changelog and release_create actions to separate JavaScript modules (changelog.js and cleanup.js) for better maintainability and testability. Added comprehensive unit tests for both modules. This refactor improves code organization and enables easier testing and future enhancements.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage