feat(release_create): add virustotal scanning #13
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #13 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 3 3
Lines 384 384
=========================================
Hits 384 384
Flags with carried forward coverage won't be shown. Click here to find out more. |
ReenigneArcher
force-pushed
the
feat/release_create/add-virustotal-scanning
branch
from
906485a to
40cb92b
Compare
ReenigneArcher
force-pushed
the
feat/release_create/add-virustotal-scanning
branch
from
40cb92b to
8214656
Compare
|
There was a problem hiding this comment.
Pull Request Overview
Adds VirusTotal automated scanning to the release_create action by generating a test binary, accepting an API key, running a scan, and appending results to the release body.
- Introduce
pre-ci.shto produce a dummy binary for scanning - Update CI matrix and
action.ymlto acceptvirustotal_api_keyand trigger a scan + formatting step - Document the new input and inject the secret in the workflow
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| actions/release_create/pre-ci.sh | Create and validate a dummy binary for VirusTotal testing |
| actions/release_create/ci-matrix.json | Add dist/* artifacts and virustotal_api_key to the CI matrix |
| actions/release_create/action.yml | Define new input, run VirusTotal scan, format and override release body |
| actions/release_create/README.md | Document the virustotal_api_key input |
| .github/workflows/ci.yml | Populate VIRUSTOTAL_API_KEY in workflow parameters |
Comments suppressed due to low confidence (3)
actions/release_create/action.yml:88
- The single quotes prevent
${{ steps.vt.outputs.json }}from being expanded. Use double quotes instead:if [ -n "${{ steps.vt.outputs.json }}" ].
if [ -n '${{ steps.vt.outputs.json }}' ]; then
actions/release_create/action.yml:97
- Single quotes around
${{ steps.vt.outputs.json }}will not expand the output. Switch to double quotes:printf '%s\n' "${{ steps.vt.outputs.json }}".
printf '%s\n' '${{ steps.vt.outputs.json }}' | jq -r '.[] | "- [\(.name)](\(.link))"' >> release_body.md
actions/release_create/action.yml:83
- [nitpick] The here-doc is indented, which may introduce unwanted leading spaces in the release body. Consider using an unindented
<< 'BODY_EOF'or a tab-stripping<<- 'BODY_EOF'syntax.
cat > release_body.md << 'BODY_EOF'
| @@ -0,0 +1,26 @@ | |||
| #!/bin/bash | |||
There was a problem hiding this comment.
Consider adding set -euo pipefail after the shebang to fail early on errors and improve script robustness.
Description
This PR adds virustotal automated scanning to the
release_createactionScreenshot
Issues Fixed or Closed
Type of Change
.github/...)Checklist