Skip to content

Conversation

@BigBrainAFK
Copy link
Contributor

Description

This PR moves the check for the UPnP enable flag up to the top of the start function.
This way if someone disables UPnP it is truly disabled and does not try to find any UPnP device to begin with.

Issues Fixed or Closed

(No issue was made for this)

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

@ReenigneArcher ReenigneArcher merged commit 5477f58 into LizardByte:nightly Jan 10, 2023
@BigBrainAFK BigBrainAFK deleted the fix/upnp-flag branch January 25, 2023 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants