Skip to content

Conversation

@cgutman
Copy link
Collaborator

@cgutman cgutman commented Jan 4, 2023

Description

This PR includes some minor cosmetic fixes/improvements to the UI and docs.

  • Added "AMD" to the "AMF Encoder" tab title to make it more clear to users
  • Fixed some encoder tabs that were not hidden on unsupported platforms
  • Fixed misspelling of QP
  • Clarify that the "min_threads" option only impacts the software encoder
  • Encoder configuration tabs are sorted in order of encoder priority

Screenshot

image

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Dependency update (updates to dependencies)
  • Documentation update (changes to documentation)
  • Repository update (changes to repository files, e.g. .github/...)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the in code docstring/documentation-blocks for new or existing methods/components

Branch Updates

LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.

  • I want maintainers to keep my branch updated

Copy link
Member

@ReenigneArcher ReenigneArcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I didn't even realize we had a mechanism to display certain settings based on the platform. Good to know.

@ReenigneArcher ReenigneArcher mentioned this pull request Jan 4, 2023
11 tasks
@ReenigneArcher ReenigneArcher merged commit 08cb5fc into LizardByte:nightly Jan 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants