Fix UPnP IGD detection #689
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the UPnP status messages and allows the detection of UPnP iuds that are in status 2 (not connected)
An IGD in status 1 is the IGD of the network and connected (has an external IP which isn't in a private block)
An IGD in status 2 is also the IGD of the network but may not be connected due to various reasons (no external IP or external IP in a private IPv4/IPv6 block)
Sunshine should not discard an IGD of status 2 as the reason to the unconnected status is not determinable by an outside source and has to be fixed by the network administrator/owner. This can be a misconfigured second router or just the ISP being down due to various reasons.
We still do not attempt to open ports on a status 3 as this is just a UPnP device which is not an IGD.
Type of Change
.github/...)Checklist
Branch Updates
LizardByte requires that branches be up-to-date before merging. This means that after any PR is merged, this branch
must be updated before it can be merged. You must also
Allow edits from maintainers.