Skip to content

Conversation

@ReenigneArcher
Copy link
Member

Description

  • Add clang linter
  • Add dependabot (github action dependencies only)

Type of Change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the documentation blocks for new or existing components

- Add upload artifacts
- Use job strategy matrix
  - inplace True allows artifacts to be uploaded; however workflow succeeds even if there are errors
  - inplace False fails workflow if there are errors
- Fix syntax error
@ReenigneArcher
Copy link
Member Author

The modified c++ files are the results of the linter. The action uploads them as an artifact.

@TheElixZammuto
Copy link
Member

What happens if the linter finds errors in the code style? Does it fail the pipeline or it just provides the changed files?

@ReenigneArcher
Copy link
Member Author

What happens if the linter finds errors in the code style? Does it fail the pipeline or it just provides the changed files?

It's a matrix strategy. So when "inplace" is true the workflow succeeds and the artifacts are uploaded. Then it runs with "inplace" as false and will fail the workflow if there are errors.

The latest failure should show that as an example.

@TheElixZammuto
Copy link
Member

What happens if the linter finds errors in the code style? Does it fail the pipeline or it just provides the changed files?

It's a matrix strategy. So when "inplace" is true the workflow succeeds and the artifacts are uploaded. Then it runs with "inplace" as false and will fail the workflow if there are errors.

The latest failure should show that as an example.
Gotcha, so it's the best of both worlds! ^_^

@ReenigneArcher ReenigneArcher merged commit a4fa42f into nightly Feb 17, 2022
@ReenigneArcher ReenigneArcher deleted the add-clang-linter branch February 17, 2022 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants