Skip to content

Conversation

@Garmelon
Copy link
Contributor

@Garmelon Garmelon commented Nov 23, 2025

Description

At this point in time, cuda depends on "gcc" (without any version suffix). This breaks the build, which expects there to always be a version suffix.

This PR extends the cuda gcc version detection logic to handle this case, with the expectation that in the future, cuda may be a gcc version behind again. The simpler option would've been to get rid of the gcc version detection logic entirely, but that one may break again in the future.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

At this point in time, cuda depends on "gcc" (without any version
suffix). This breaks the build, which expects there to always be a
version suffix.
@sonarqubecloud
Copy link

@ReenigneArcher ReenigneArcher merged commit fe07501 into LizardByte:master Nov 24, 2025
48 of 50 checks passed
@codecov
Copy link

codecov bot commented Nov 24, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 14.19%. Comparing base (d0aefe0) to head (be9962b).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4442      +/-   ##
==========================================
- Coverage   14.25%   14.19%   -0.07%     
==========================================
  Files          89       89              
  Lines       18942    18942              
  Branches     8682     8682              
==========================================
- Hits         2701     2689      -12     
+ Misses      15230    12975    -2255     
- Partials     1011     3278    +2267     
Flag Coverage Δ
FreeBSD-14.3-aarch64 ?
FreeBSD-14.3-amd64 13.54% <ø> (-0.01%) ⬇️
Linux-AppImage 11.55% <ø> (ø)
Windows-AMD64 13.33% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 44 files with indirect coverage changes

@codecov
Copy link

codecov bot commented Nov 24, 2025

Bundle Report

Bundle size has no change ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants