Skip to content

fix(video): fix leaky abstraction in ogl luma shader #4404

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 1 commit into from
Nov 8, 2025
Merged

fix(video): fix leaky abstraction in ogl luma shader #4404

ReenigneArcher merged 1 commit into from
Nov 8, 2025

Conversation

@ns6089
Copy link
Contributor

@ns6089 ns6089 commented Nov 8, 2025

Description

The shader ignored part of color conversion matrix. Should hopefully fix #4403

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Nov 8, 2025

Bundle Report

Bundle size has no change ✅

@codecov
Copy link

codecov bot commented Nov 8, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 12.08%. Comparing base (8836db5) to head (13f9ebf).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #4404    +/-   ##
========================================
  Coverage   12.08%   12.08%            
========================================
  Files          87       87            
  Lines       17595    17595            
  Branches     8096     8096            
========================================
  Hits         2126     2126            
- Misses      14566    14748   +182     
+ Partials      903      721   -182
Flag Coverage Δ
Linux-AppImage 11.57% <ø> (ø)
Windows-AMD64 13.35% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 21 files with indirect coverage changes

@cgutman cgutman mentioned this pull request Nov 8, 2025
Closed
2 tasks
@ns6089
Copy link
Contributor Author

ns6089 commented Nov 8, 2025

@ReenigneArcher Could you please disable newline linter until it stops triggering on existing code? If I add newline to the modified file, we end up with inconsistent files. If I modify other files too, we end with unrelated git log message.

@ReenigneArcher
Copy link
Member

ReenigneArcher commented Nov 8, 2025 •
edited
Loading

@ns6089 this linter only runs on modified files. The linter is not intelligent enough to know if the issue existed previously or not.

I can ignore the rule for this PR though. Ideally these get fixed over time.

@ReenigneArcher ReenigneArcher merged commit 49197c7 into LizardByte:master Nov 8, 2025
47 of 49 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Colors wrong since PR 4387 three days ago

2 participants

@ns6089 @ReenigneArcher