fix(config): Add missing framerateX100 fields at the initializers for the video::config_t literals #4391
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… video::config_t literals.
ReenigneArcher
force-pushed
the
fix-config-constants
branch
from
5229971 to
ef64fa0
Compare
|
Bundle ReportBundle size has no change ✅ |
mcourteaux
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4391 +/- ##
==========================================
- Coverage 12.10% 12.05% -0.06%
==========================================
Files 87 87
Lines 17595 17595
Branches 8096 8096
==========================================
- Hits 2130 2121 -9
+ Misses 14743 14571 -172
- Partials 722 903 +181
Flags with carried forward coverage won't be shown. Click here to find out more.
|
Member
|
@andygrundman FYI |
ReenigneArcher
changed the title
Contributor
Author
|
This Docker CI thing is a fluke, right? This can be merged I think? |
Member
Not due to this PR. |
Contributor
Author
|
The field was described as optional. Perhaps I should initialize them to 0 instead of 6000? |
Collaborator
|
Either way is fine. |
qiin2333
pushed a commit
to qiin2333/foundation-sunshine
that referenced
this pull request
Nov 8, 2025
… the video::config_t literals (LizardByte#4391) fix(config): Add missing frameX100 fields at the initializers for the video::config_t literals.
This was referenced Nov 20, 2025
Nonary
pushed a commit
to Nonary/vibeshine
that referenced
this pull request
Jan 13, 2026
… the video::config_t literals (LizardByte#4391) fix(config): Add missing frameX100 fields at the initializers for the video::config_t literals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes bugs introduced by #4019.
Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage