fix(launch): Fix several launch failure conditions (exceptions thrown in child.wait, and boost::split_unix) #4390
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mcourteaux
changed the title
Bundle ReportBundle size has no change ✅ |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4390 +/- ##
==========================================
- Coverage 14.94% 14.19% -0.76%
==========================================
Files 63 89 +26
Lines 13726 18936 +5210
Branches 6476 8677 +2201
==========================================
+ Hits 2052 2688 +636
- Misses 8686 12969 +4283
- Partials 2988 3279 +291
Flags with carried forward coverage won't be shown. Click here to find out more.
|
mcourteaux
force-pushed
the
fix-exceptions
branch
from
8b72947 to
3b11477
Compare
ReenigneArcher
changed the title
Contributor
Author
|
Can somebody update me on this? Should anything happen before merge? |
This comment was marked as resolved.
This comment was marked as resolved.
mcourteaux
force-pushed
the
fix-exceptions
branch
from
3b11477 to
5848551
Compare
This comment was marked as resolved.
This comment was marked as resolved.
mcourteaux
force-pushed
the
fix-exceptions
branch
from
46cbd07 to
15bdb29
Compare
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
…ch disrupted control flow. Surrounded with try-catch, reporting a helpful message. improve(launch): In case unexpected exceptions are thrown during launch or resume, an empty an error is now logged to help the user analyze this. fix(process): child.wait() may throw, replaced it with the std::error_code variant.
mcourteaux
force-pushed
the
fix-exceptions
branch
from
15bdb29 to
238312d
Compare
This comment was marked as resolved.
This comment was marked as resolved.
|
qiin2333
pushed a commit
to qiin2333/foundation-sunshine
that referenced
this pull request
Nov 14, 2025
… in child.wait, and boost::split_unix) (LizardByte#4390)
ShadowLemoon
added a commit
to ShadowLemoon/Sunshine-Foundation
that referenced
this pull request
Nov 17, 2025
…s thrown in child.wait, and boost::split_unix) (LizardByte#4390)" This reverts commit 57f0263.
ShadowLemoon
added a commit
to ShadowLemoon/Sunshine-Foundation
that referenced
this pull request
Nov 17, 2025
…s thrown in child.wait, and boost::split_unix) (LizardByte#4390)" This reverts commit 57f0263.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
\!as escape sequence. The\got added by saving/loading the json file I think, not sure.This fixes the Malformed XML error moonlight-qt showed in my situation.
Screenshot
Issues Fixed or Closed
Resolves #4038.
Roadmap Issues
Type of Change
Checklist
AI Usage