Skip to content

feat(video): use unified color conversion matrix generator #4387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 1 commit into from
Nov 5, 2025
Merged

feat(video): use unified color conversion matrix generator #4387

ReenigneArcher merged 1 commit into from
Nov 5, 2025

Conversation

@ns6089
Copy link
Contributor

@ns6089 ns6089 commented Nov 2, 2025

Description

Sunshine's side of changes discussed in moonlight-stream/moonlight-qt#1667
Probably shouldn't be merged until the next version of moonlight-qt is released, or at least it's been very close to release.
Hasn't been tested on Linux. Don't think it will break anything there, but can't give a 100% guarantee.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov
Copy link

codecov bot commented Nov 3, 2025

Bundle Report

Bundle size has no change ✅

@codecov
Copy link

codecov bot commented Nov 3, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 12.11%. Comparing base (eb72930) to head (73a62c7).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/video_colorspace.cpp 0.00% 4 Missing ⚠️
src/platform/windows/display_vram.cpp 0.00% 3 Missing ⚠️
src/platform/linux/graphics.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4387      +/-   ##
==========================================
+ Coverage   12.09%   12.11%   +0.01%     
==========================================
  Files          87       87              
  Lines       17612    17595      -17     
  Branches     8097     8096       -1     
==========================================
  Hits         2131     2131              
+ Misses      14579    14562      -17     
  Partials      902      902
Flag Coverage Δ
Linux-AppImage 11.63% <0.00%> (+0.01%) ⬆️
Windows-AMD64 13.43% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/linux/graphics.cpp 2.24% <0.00%> (ø)
src/platform/windows/display_vram.cpp 8.95% <0.00%> (ø)
src/video_colorspace.cpp 27.58% <0.00%> (+4.50%) ⬆️

@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 3, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
4 New issues
4 New Code Smells (required ≤ 0)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@cgutman
Copy link
Collaborator

cgutman commented Nov 5, 2025

IIUC, every client except Moonlight Qt and even all Qt renderers except D3D11VA and Metal are expecting the standard matrix which this PR generates (IOW, they are already broken today). Even those two renderers would only be problematic when streaming in 10-bit, since 8-bit limited is perfectly accurate and 8-bit full is never requested by either of those renderers. If all that's true, I think it's probably fine to merge this now.

@ns6089
Copy link
Contributor Author

ns6089 commented Nov 5, 2025

Sounds fine by me, we can always point people to nightly builds of moonlight-qt if there are going to be complaints.

@cgutman I also saw shader code pop up in moonlight-ios discussion, but that might have been some fork.

@ReenigneArcher ReenigneArcher merged commit cdb7e2b into LizardByte:master Nov 5, 2025
46 of 49 checks passed
@rubin55 rubin55 mentioned this pull request Nov 8, 2025
Closed
2 tasks
qiin2333 pushed a commit to qiin2333/foundation-sunshine that referenced this pull request Nov 8, 2025
feat(video): use unified color conversion matrix generator (LizardByt…
29e45cb 
…e#4387)
qiin2333 pushed a commit to qiin2333/foundation-sunshine that referenced this pull request Nov 8, 2025
feat(video): use unified color conversion matrix generator (LizardByt…
468442f 
…e#4387)
@softyoda softyoda mentioned this pull request Dec 13, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ns6089 @cgutman @ReenigneArcher