Skip to content

build(rpm): Update Fedora spec and CUDA math_functions.h patch for Fedora 43+ #4353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 3 commits into from
Oct 25, 2025
Merged

build(rpm): Update Fedora spec and CUDA math_functions.h patch for Fedora 43+ #4353

ReenigneArcher merged 3 commits into from
Oct 25, 2025

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Oct 23, 2025 •
edited
Loading

Description

This makes the math_function patches apply to Fedora 42 and above instead of strictly Fedora 42. It also adjusts the patches so they work on F43+.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@codecov
Copy link

codecov bot commented Oct 23, 2025

Bundle Report

Bundle size has no change ✅

@codecov
Copy link

codecov bot commented Oct 23, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 12.10%. Comparing base (8df1003) to head (157bddc).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff            @@
##           master    #4353    +/-   ##
========================================
  Coverage   12.10%   12.10%            
========================================
  Files          87       87            
  Lines       17610    17610            
  Branches     8095     8095            
========================================
  Hits         2131     2131            
- Misses      14577    14756   +179     
+ Partials      902      723   -179
Flag Coverage Δ
Linux-AppImage 11.62% <ø> (ø)
Windows-AMD64 13.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 21 files with indirect coverage changes

@ReenigneArcher
build(rpm): Update CUDA patch condition for Fedora 42+
0b145ee 
Changed the math_functions.h patch logic to apply for Fedora version 42 and above, instead of only Fedora 42. This ensures compatibility with newer Fedora releases affected by the same issue.
@ReenigneArcher
Add noexcept to rsqrt and rsqrtf declarations
74cac69 
Updated the CUDA math_functions.h patch files for both aarch64 and x86_64 to declare rsqrt and rsqrtf functions with noexcept (true). This improves exception safety and clarifies that these device functions do not throw exceptions.
@ReenigneArcher
Add noexcept to math function declarations in patches
157bddc 
Updated aarch64 and x86_64 math_functions.patch files to declare rsqrt, sinpi, cospi, rsqrtf, sinpif, and cospif functions as noexcept (true) for improved exception safety and clarity.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 25, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ReenigneArcher ReenigneArcher changed the title build(rpm): Update Fedora spec to patch for Fedora 42 and above build(rpm): Update Fedora spec and CUDA math_functions.h patch for Fedora 43+ Oct 25, 2025
@ReenigneArcher ReenigneArcher merged commit 7ecb781 into master Oct 25, 2025
76 of 77 checks passed
@ReenigneArcher ReenigneArcher deleted the ReenigneArcher-patch-1 branch October 25, 2025 03:45
@ReenigneArcher ReenigneArcher mentioned this pull request Oct 30, 2025
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ReenigneArcher