fix(windows): Memory leak when EnumAdapters1 uses dxgi::adapter_t address as parameter #4340
Conversation
Bundle ReportBundle size has no change ✅ |
|
Thank you for the PR! Could you fix the lint errors? Also, do you think this will fix the memory leak reported in #4338? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4340 +/- ##
========================================
Coverage 12.10% 12.10%
========================================
Files 87 87
Lines 17610 17610
Branches 8095 8096 +1
========================================
Hits 2131 2131
+ Misses 14756 14577 -179
- Partials 723 902 +179
Flags with carried forward coverage won't be shown. Click here to find out more.
|
xd-byte
force-pushed
the
fix-windows-memory-leak
branch
from
f42177b to
95db540
Compare
|
@xd-byte the commit is coauthored by another git account, is that intentional? |
xd-byte
force-pushed
the
fix-windows-memory-leak
branch
from
95db540 to
05d49be
Compare
Thanks for noticing! I’ve updated the commits so the author now matches my GitHub account and force-pushed the branch. |
…ress as parameter
ReenigneArcher
force-pushed
the
fix-windows-memory-leak
branch
from
05d49be to
5e37626
Compare
|
2 participants
This PR fixes a memory leak issue in the Windows DXGI adapter enumeration code. Previously, dxgi::adapter_t instances were passed directly to EnumAdapters1(), which expects a raw IDXGIAdapter1**. This could cause the internal pointer of dxgi::adapter_t (a uniq_ptr wrapper) to be overwritten, leading to potential memory leaks or invalid pointer access.