Skip to content

fix(web-ui): translation function in DisplayOutputSelector label #4328

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 1 commit into from
Oct 12, 2025
Merged

fix(web-ui): translation function in DisplayOutputSelector label #4328

ReenigneArcher merged 1 commit into from
Oct 12, 2025
+1 −1

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Oct 12, 2025 •
edited
Loading

Description

Replaces the incorrect $tp translation function with $t for the 'config.output_name' label in DisplayOutputSelector.vue.

The field was not being properly translated. This bug originated in #4215 when the localization values were consolidated.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher
fix(web-ui): translation function in DisplayOutputSelector label
f066e59 
Replaces the incorrect $tp translation function with $t for the 'config.output_name' label in DisplayOutputSelector.vue.
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 12, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@codecov
Copy link

codecov bot commented Oct 12, 2025

Bundle Report

Bundle size has no change ✅

@codecov
Copy link

codecov bot commented Oct 12, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 12.12%. Comparing base (08454f7) to head (f066e59).
⚠️ Report is 74 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4328      +/-   ##
==========================================
+ Coverage   12.10%   12.12%   +0.02%     
==========================================
  Files          87       87              
  Lines       17610    17610              
  Branches     8095     8095              
==========================================
+ Hits         2131     2136       +5     
+ Misses      14756    14751       -5     
  Partials      723      723
Flag Coverage Δ
Linux-AppImage 11.62% <ø> (ø)
Windows-AMD64 13.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 1 file with indirect coverage changes

@ReenigneArcher ReenigneArcher merged commit a8e03a2 into master Oct 12, 2025
48 checks passed
@ReenigneArcher ReenigneArcher deleted the fix/web-ui/platform-translation-for-output_name branch October 12, 2025 18:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ReenigneArcher