build(linux): enable cpack auto dependencies #4323
Merged
+4
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
21 tasks
Bundle ReportBundle size has no change ✅ |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #4323 +/- ##
========================================
Coverage 11.98% 11.98%
========================================
Files 87 87
Lines 17572 17572
Branches 8076 8076
========================================
Hits 2106 2106
+ Misses 14748 14569 -179
- Partials 718 897 +179
Flags with carried forward coverage won't be shown. Click here to find out more. |
PVermeer
changed the title
PVermeer
force-pushed
the
build_linux_boost_libicu
branch
from
f87f116 to
4f7cbb1
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As mentioned in PR #4304 this PR is meant to fix the
libicuissue on debian. After some further investigation I noticed thatSunshine/cmake/packaging/linux.cmake
Lines 96 to 97 in f52891d
The only issue I could find right now is that it needs the
filepackage on Debian-based distros. So adding the file to the build dependencies and running all the builds again fixes this issue (+ maybe some future issues).If this is not acceptable I also have a fix specifically for
libicuin b7b9e44 using the FindICU module.Screenshot
Issues Fixed or Closed
Roadmap Issues
Type of Change
Checklist
AI Usage