Skip to content

Conversation

@PVermeer
Copy link
Contributor

@PVermeer PVermeer commented Oct 7, 2025

Description

As noted in #4304 (comment) builds on older distros (e.g. ubuntu-22), with newer compilers (and newer c++ features), will fail at runtime with dynamic linking errors (libstdc++). As discussed in #4304 this can be applied to all linux builds.

The binary will be about 600kb bigger.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@PVermeer PVermeer force-pushed the build_static_link_linux branch from f0bbc48 to da79708 Compare October 7, 2025 13:52
@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 7, 2025

@codecov
Copy link

codecov bot commented Oct 7, 2025

Bundle Report

Bundle size has no change ✅

@codecov
Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 11.98%. Comparing base (8372c37) to head (da79708).
⚠️ Report is 80 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4321   +/-   ##
=======================================
  Coverage   11.98%   11.98%           
=======================================
  Files          87       87           
  Lines       17572    17572           
  Branches     8076     8076           
=======================================
  Hits         2106     2106           
  Misses      14569    14569           
  Partials      897      897           
Flag Coverage Δ
Linux-AppImage 11.49% <ø> (ø)
Windows-AMD64 13.26% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

@ReenigneArcher ReenigneArcher merged commit f52891d into LizardByte:master Oct 7, 2025
48 checks passed
@PVermeer PVermeer deleted the build_static_link_linux branch October 9, 2025 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants