Skip to content

build(deps): bump boost to 1.89 #4253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 1 commit into from
Nov 2, 2025
Merged

build(deps): bump boost to 1.89 #4253

ReenigneArcher merged 1 commit into from
Nov 2, 2025

Conversation

@ReenigneArcher
Copy link
Member

@ReenigneArcher ReenigneArcher commented Sep 13, 2025 •
edited
Loading

Description

Bump boost to 1.89.

Simple-Web-Server is not 100% compatible with boost 1.89, although it works in some build environments. It fails with flatpak and homebrew boost is set as a dependency. There doesn't seem to be any issue when using fetch content. In any event, I have submitted a PR https://gitlab.com/eidheim/Simple-Web-Server/-/merge_requests/283

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@ReenigneArcher ReenigneArcher marked this pull request as draft September 13, 2025 03:07
@ReenigneArcher ReenigneArcher force-pushed the build/deps/bump-boost-to-1.89 branch from 2e9daae to eefff10 Compare September 13, 2025 03:28
@codecov
Copy link

codecov bot commented Sep 13, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 12.09%. Comparing base (3d2fca7) to head (bc38359).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #4253   +/-   ##
=======================================
  Coverage   12.09%   12.09%           
=======================================
  Files          87       87           
  Lines       17612    17612           
  Branches     8097     8097           
=======================================
  Hits         2131     2131           
  Misses      14758    14758           
  Partials      723      723
Flag Coverage Δ
Linux-AppImage 11.62% <ø> (ø)
Windows-AMD64 13.41% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/platform/common.h 24.13% <ø> (ø)
src/platform/linux/misc.cpp 10.00% <ø> (ø)
src/platform/windows/input.cpp 0.63% <ø> (ø)

@ReenigneArcher ReenigneArcher force-pushed the build/deps/bump-boost-to-1.89 branch from eefff10 to ffee588 Compare September 13, 2025 03:51
@ReenigneArcher ReenigneArcher mentioned this pull request Sep 13, 2025
Merged
21 tasks
@FineWolf

This comment was marked as resolved.

Sign in to view
@ReenigneArcher ReenigneArcher force-pushed the build/deps/bump-boost-to-1.89 branch 2 times, most recently from 5757a62 to 8fff04e Compare September 13, 2025 05:32
@codecov
Copy link

codecov bot commented Sep 13, 2025

Bundle Report

Bundle size has no change ✅

@ReenigneArcher ReenigneArcher force-pushed the build/deps/bump-boost-to-1.89 branch 2 times, most recently from bec5438 to cf546cb Compare September 13, 2025 14:05
@ReenigneArcher
Copy link
Member Author

ReenigneArcher commented Sep 13, 2025

For the failing Arch build, it seems like a CI issue because I can build this commit just fine on my system.

Yea, that's right. I forgot we have that intermittent issue in the Arch docker build (docker/build-push-action#1385)

@ReenigneArcher
Copy link
Member Author

ReenigneArcher commented Sep 13, 2025 •
edited
Loading

I'm at a loss on why the boost "system" component cannot be found in the flatpak, or homebrew builds, but it can be found in other builds.

I found this, which might be related, but not sure what to make of it. boostorg/system@7a495bb

Edit: upstream PR => https://gitlab.com/eidheim/Simple-Web-Server/-/merge_requests/283

@ReenigneArcher ReenigneArcher force-pushed the build/deps/bump-boost-to-1.89 branch from cf546cb to 9087ca8 Compare September 13, 2025 14:46
@ReenigneArcher
Copy link
Member Author

ReenigneArcher commented Sep 13, 2025

This seems to all be working, but I'd like to give a little time to see if Simple-Web-Server merges my PR.

@ReenigneArcher ReenigneArcher force-pushed the build/deps/bump-boost-to-1.89 branch from 1774e2a to ffdb189 Compare September 22, 2025 00:57
@ReenigneArcher ReenigneArcher force-pushed the build/deps/bump-boost-to-1.89 branch from ffdb189 to c5fb9f9 Compare October 6, 2025 21:32
@ReenigneArcher ReenigneArcher mentioned this pull request Oct 21, 2025
Draft
15 tasks
@ReenigneArcher ReenigneArcher force-pushed the build/deps/bump-boost-to-1.89 branch from c5fb9f9 to a8c4091 Compare November 1, 2025 23:58
@ReenigneArcher ReenigneArcher marked this pull request as ready for review November 2, 2025 00:00
@ReenigneArcher ReenigneArcher force-pushed the build/deps/bump-boost-to-1.89 branch from a8c4091 to bc38359 Compare November 2, 2025 00:10
@sonarqubecloud
Copy link

sonarqubecloud bot commented Nov 2, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ReenigneArcher ReenigneArcher merged commit 875ad1d into master Nov 2, 2025
47 of 49 checks passed
@ReenigneArcher ReenigneArcher deleted the build/deps/bump-boost-to-1.89 branch November 2, 2025 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ReenigneArcher @FineWolf