Skip to content

fix(config): ensure apps.json is writeable #4249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 1 commit into from
Oct 26, 2025
Merged

fix(config): ensure apps.json is writeable #4249

ReenigneArcher merged 1 commit into from
Oct 26, 2025

Conversation

@SuperSandro2000
Copy link
Contributor

@SuperSandro2000 SuperSandro2000 commented Sep 8, 2025

Description

When the config file is copied on NixOS from the nix store the file is readonly for everyone and sunshine fails to save changes in the web ui.

Screenshot

Issues Fixed or Closed

Roadmap Issues

Type of Change

  • feat: New feature (non-breaking change which adds functionality)
  • fix: Bug fix (non-breaking change which fixes an issue)
  • docs: Documentation only changes
  • style: Changes that do not affect the meaning of the code (white-space, formatting, missing semicolons, etc.)
  • refactor: Code change that neither fixes a bug nor adds a feature
  • perf: Code change that improves performance
  • test: Adding missing tests or correcting existing tests
  • build: Changes that affect the build system or external dependencies
  • ci: Changes to CI configuration files and scripts
  • chore: Other changes that don't modify src or test files
  • revert: Reverts a previous commit
  • BREAKING CHANGE: Introduces a breaking change (can be combined with any type above)

Checklist

  • Code follows the style guidelines of this project
  • Code has been self-reviewed
  • Code has been commented, particularly in hard-to-understand areas
  • Code docstring/documentation-blocks for new or existing methods/components have been added or updated
  • Unit tests have been added or updated for any new or modified functionality

AI Usage

  • None: No AI tools were used in creating this PR
  • Light: AI provided minor assistance (formatting, simple suggestions)
  • Moderate: AI helped with code generation or debugging specific parts
  • Heavy: AI generated most or all of the code changes

@sonarqubecloud
Copy link

sonarqubecloud bot commented Sep 8, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@SuperSandro2000 SuperSandro2000 changed the title Make sure the config is writable after being copied fix: make sure the config is writable after being copied Sep 8, 2025
@codecov
Copy link

codecov bot commented Sep 8, 2025

Bundle Report

Bundle size has no change ✅

@codecov
Copy link

codecov bot commented Sep 8, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 12.12%. Comparing base (a7f03c2) to head (3333b36).
⚠️ Report is 1 commits behind head on master.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
src/config.cpp 0.00% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #4249      +/-   ##
==========================================
+ Coverage   12.10%   12.12%   +0.02%     
==========================================
  Files          87       87              
  Lines       17610    17612       +2     
  Branches     8096     8097       +1     
==========================================
+ Hits         2131     2136       +5     
+ Misses      14756    14753       -3     
  Partials      723      723
Flag Coverage Δ
Linux-AppImage 11.62% <0.00%> (-0.01%) ⬇️
Windows-AMD64 13.41% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/config.cpp 0.00% <0.00%> (ø)

... and 1 file with indirect coverage changes

@SuperSandro2000 SuperSandro2000 marked this pull request as ready for review September 8, 2025 15:53
@ReenigneArcher
Copy link
Member

ReenigneArcher commented Sep 8, 2025

To confirm, the changes in the PR affect the apps.json, not the sunshine.conf. You are having issues saving changes to apps or to the configuration?

@snichola
Copy link

snichola commented Oct 26, 2025

Chiming in as an affected user, the issue is saving to apps.json.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Oct 26, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ReenigneArcher ReenigneArcher changed the title fix: make sure the config is writable after being copied fix(config): ensure apps.json is writeable Oct 26, 2025
@ReenigneArcher ReenigneArcher merged commit f1a6675 into LizardByte:master Oct 26, 2025
47 of 49 checks passed
qiin2333 pushed a commit to qiin2333/foundation-sunshine that referenced this pull request Nov 2, 2025
fix(config): ensure apps.json is writeable (LizardByte#4249)
7605e06
qiin2333 pushed a commit to qiin2333/foundation-sunshine that referenced this pull request Nov 3, 2025
fix(config): ensure apps.json is writeable (LizardByte#4249)
d836c88
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@SuperSandro2000 @ReenigneArcher @snichola