Skip to content

Add missing EGL extension for linux #345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
ReenigneArcher merged 3 commits into from
Oct 26, 2022
Merged

Add missing EGL extension for linux #345

ReenigneArcher merged 3 commits into from
Oct 26, 2022

Conversation

@brownj85
Copy link
Contributor

@brownj85 brownj85 commented Aug 26, 2022 •
edited
Loading

Description

Adds 'EGL_EXT_image_dma_buf_import_modifiers' to the list of required EGL extensions when initializing display. This extension is required to support the many of the parameters passed to eglCreateImage(). The parameters provided by the extension are listed here:
https://registry.khronos.org/EGL/extensions/EXT/EGL_EXT_image_dma_buf_import_modifiers.txt

They are used in src/platform/linux/graphics.cpp.

Adding this extension fixes the EGL_BAD_ATTRIBUTE (00003004) error code from eglCreateImage(). It may also fix the EGL_BAD_ACCESS (00003002) error but I can't verify.

Issues Fixed or Closed

Type of Change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring/documentation-blocks for new or existing methods/components

@CLAassistant
Copy link

CLAassistant commented Aug 26, 2022 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@github-actions github-actions bot changed the base branch from master to nightly August 26, 2022 22:57
@github-actions
Copy link

github-actions bot commented Aug 26, 2022

Your PR was set to master, PRs should be sent to nightly.
The base branch of this PR has been automatically changed to nightly.
Please check that there are no merge conflicts

@ReenigneArcher
Copy link
Member

ReenigneArcher commented Aug 27, 2022

Thanks for the contribution... once you sign the CLA I will build this version and ask for testers.

@ReenigneArcher ReenigneArcher mentioned this pull request Aug 30, 2022
Closed
@nougatbyte nougatbyte mentioned this pull request Sep 18, 2022
Closed
@ReenigneArcher ReenigneArcher merged commit c9c93a2 into LizardByte:nightly Oct 26, 2022
Nonary pushed a commit to Nonary/vibeshine that referenced this pull request Oct 3, 2025
@ClassicOldSong
Fix LizardByte#345
dca9092
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Error: Couldn't import RGB Image: 00003004

3 participants

@brownj85 @CLAassistant @ReenigneArcher